-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syms for legacy numeric constants diag items #121667
syms for legacy numeric constants diag items #121667
Conversation
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1c28a2c): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.218s -> 650.944s (-0.04%) |
Regression seems likely to be noise (bimodality) or not significant enough to investigate further. Marking as triaged. Some of the improvements seem genuine. |
…nstants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? `@Nilstrieb` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!
…nstants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? ``@Nilstrieb`` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!
…nstants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? ```@Nilstrieb``` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!
Rollup merge of rust-lang#122271 - pitaj:diag_items-legacy_numeric_constants, r=Nilstrieb Fix legacy numeric constant diag items - missed syms for usize/isize - missed diag items on unsigned integers For rust-lang/rust-clippy#12312 r? ```@Nilstrieb``` Follow-up to rust-lang#121272, rust-lang#121361, rust-lang#121667 This should be the last one 🤞 Sorry!
Missed these in #121272 and #121361, woops.
For rust-lang/rust-clippy#12312
r? @Nilstrieb