Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attribute validation on associated items in traits #121545

Merged

Conversation

gvozdvmozgu
Copy link
Contributor

#121537, fixed attribute validation on associated items in traits

@rustbot
Copy link
Collaborator

rustbot commented Feb 24, 2024

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2024
@fmease
Copy link
Member

fmease commented Feb 24, 2024

Not sure why @nnethercote's PR started to trigger an ICE (I don't have time to investigate) but I've been aware of the missing attr visit call for some time already (cc #119924 where I mention it).

r? fmease

@rustbot rustbot assigned fmease and unassigned estebank Feb 24, 2024
@fmease
Copy link
Member

fmease commented Feb 24, 2024

Since this makes the reproducer and likely many other snippets go from pass on stable to error on this branch this means it's a breaking change (ignoring the ICE on nightly).
I'm therefore gonna check crater.

@bors try

@bors
Copy link
Contributor

bors commented Feb 24, 2024

⌛ Trying commit 8b576d5 with merge 7ee7645...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 24, 2024
…-associated-items, r=<try>

fix attribute validation on associated items in traits

rust-lang#121537, fixed attribute validation on associated items in traits
@bors
Copy link
Contributor

bors commented Feb 24, 2024

☀️ Try build successful - checks-actions
Build commit: 7ee7645 (7ee76453dd3eae6de6c1351f26482bed63b01beb)

@fmease
Copy link
Member

fmease commented Feb 24, 2024

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-121545 created and queued.
🤖 Automatically detected try build 7ee7645
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2024
@saethlin saethlin linked an issue Feb 25, 2024 that may be closed by this pull request
@nnethercote
Copy link
Contributor

Not sure why @nnethercote's PR started to trigger an ICE

That's easy: I added a let guar = self.dcx().has_errors().unwrap(); here

In hindsight, perhaps a span_delayed_bug would have been more appropriate, but this problem would have shown up anyway.

I've been aware of the missing attr visit call for some time already (cc #119924 where I mention it).

So I guess we can call #121120 a success, because it (re-)exposed this AST validation problem.

@craterbot
Copy link
Collaborator

🚧 Experiment pr-121545 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-121545 is completed!
📊 6 regressed and 1 fixed (420397 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 8, 2024
@fmease
Copy link
Member

fmease commented Mar 11, 2024

Thanks @gvozdvmozgu for submitting a fix to async_ui! I will go through the crater report one more time later to check if any of the error/build-fail→error/build-fail entries are “#121607 situations” because those would also need to be counted as regressions.

@fmease
Copy link
Member

fmease commented Mar 16, 2024

JakeDawkins.graphql-client-302-repro is spurious btw.
Ok, I think we're good.

@fmease
Copy link
Member

fmease commented Mar 16, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2024

📌 Commit 8b576d5 has been approved by fmease

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
Rollup of 9 pull requests

Successful merges:

 - rust-lang#117918 (Add `wasm_c_abi` `future-incompat` lint)
 - rust-lang#121545 (fix attribute validation on associated items in traits)
 - rust-lang#121720 (Split refining_impl_trait lint into _reachable, _internal variants)
 - rust-lang#122270 (fix `long-linker-command-lines` failure caused by `rust.rpath=false`)
 - rust-lang#122564 (Delegation: fix ICE on duplicated associative items)
 - rust-lang#122577 (Remove obsolete parameter `speculative` from `instantiate_poly_trait_ref`)
 - rust-lang#122601 (Optimize `ptr::replace`)
 - rust-lang#122604 (Mention jieyouxu for changes to compiletest, run-make tests and the run-make-support library)
 - rust-lang#122605 (rustc-metadata: Store crate name in self-profile of metadata_register_crate)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 79c1e58 into rust-lang:master Mar 17, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
Rollup merge of rust-lang#121545 - gvozdvmozgu:fix-attribute-validation-associated-items, r=fmease

fix attribute validation on associated items in traits

rust-lang#121537, fixed attribute validation on associated items in traits
@gvozdvmozgu gvozdvmozgu deleted the fix-attribute-validation-associated-items branch March 17, 2024 02:30
@apiraino
Copy link
Contributor

apiraino commented Apr 2, 2024

by reading this comment, IIUC this breaking change needs to be mentioned in the release notes

@rustbot label +relnotes

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 2, 2024
@pnkfelix
Copy link
Member

pnkfelix commented Apr 5, 2024

I have confirmed locally that cherry-picking this commit to beta happens cleanly, resolves #121537, and presumably also resolves #123287.

Nominating for beta backport.

@rustbot label: beta-nominated

Update: okay I guess i should actually double check that it indeed resolves #123287. Will do.

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 5, 2024
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 11, 2024
@pnkfelix
Copy link
Member

Confirmed that backporting fixes the https://github.com/cyphernet-dao/nsh case, which is enough to convince me that the backport will likely resolve them all.

@cuviper cuviper mentioned this pull request Apr 11, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
[beta] backports

- fix attribute validation on associated items in traits rust-lang#121545
- Only inspect user-written predicates for privacy concerns rust-lang#123377
- Check def id before calling `match_projection_projections` rust-lang#123471
- Restore `pred_known_to_hold_modulo_regions` rust-lang#123578
- Beta revert "Use OS thread name by default" rust-lang#123533

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2024
[beta] backports

- fix attribute validation on associated items in traits rust-lang#121545
- Only inspect user-written predicates for privacy concerns rust-lang#123377
- Check def id before calling `match_projection_projections` rust-lang#123471
- Restore `pred_known_to_hold_modulo_regions` rust-lang#123578
- Beta revert "Use OS thread name by default" rust-lang#123533

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: ast lowering: None
10 participants