match lowering: Split off test_candidates into several functions and improve comments
#121374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
Nadrieril
force-pushed
the
factor-explain
branch
from
86944ce
to
893cb76
Compare
Nadrieril
changed the title
test_candidates into several functions and improve commentstest_candidates into several functions and improve comments
| // of the main candidate; but for a test like SwitchInt, we | ||
| // may want to add cases based on the candidates that are | ||
| debug!("test_candidates: test={:?} match_pair={:?}", test, match_pair); | ||
| // Most of the time, the test to perform is simply a function of the main candidate; but for |
There was a problem hiding this comment.
Comment doesn't seem to be in the correct place and can probably just be removed.
There was a problem hiding this comment.
Feels alright to me, it's trying to explain the need for add_cases_to_X shenanigans
Co-authored-by: matthewjasper <[email protected]>
|
Thank you! |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 24, 2024
…wjasper match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang#29740 because it's no longer relevant to how the code is structured today. r? `@matthewjasper`
This was referenced Feb 24, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 24, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121343 (Add examples for some methods on slices) - rust-lang#121374 (match lowering: Split off `test_candidates` into several functions and improve comments) - rust-lang#121474 (Ignore compiletest test directive migration commits) - rust-lang#121515 (promotion: don't promote int::MIN / -1) - rust-lang#121530 (Fix incorrect doc of ScopedJoinHandle::is_finished) - rust-lang#121551 (Forbid use of `extern "C-unwind"` inside standard library) - rust-lang#121556 (Use `addr_of!`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 25, 2024
Rollup merge of rust-lang#121374 - Nadrieril:factor-explain, r=matthewjasper match lowering: Split off `test_candidates` into several functions and improve comments The logic of `test_candidates` has three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods. I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about rust-lang#29740 because it's no longer relevant to how the code is structured today. r? ``@matthewjasper``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic of
test_candidateshas three steps: pick a test, sort the candidates, and generate code for everything. So I split it off into three methods.I also ended up reworking the comments that explain the algorithm. In particular I added detailed examples. I removed the digression about #29740 because it's no longer relevant to how the code is structured today.
r? @matthewjasper