Make x test tests work

[clubby789]

Fixes #97314

This makes x test tests work, and be roughly equivalent to x test tests/*. The --dry-run output is identical, except for errors on the non-test items in tests and a couple of things being in a different order (where path != struct name).

This probably needs a test, but I'm not sure of the best way to do it.

[rustbot]

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[clubby789]

Whoops, left over commit from something else

[compiler-errors]

I was about to ask why 😂

[onur-ozkan]

I think we can make this work without adding a fake build step by improving the path remapping in builder.rs:

rust/src/bootstrap/src/core/builder.rs

Lines 291 to 301 in 0987e41

	const PATH_REMAP: &[(&str, &str)] = &[("rust-analyzer-proc-macro-srv", "proc-macro-srv-cli")];
	fn remap_paths(paths: &mut Vec<&Path>) {
	for path in paths.iter_mut() {
	for &(search, replace) in PATH_REMAP {
	if path.to_str() == Some(search) {
	*path = Path::new(replace)
	}
	}
	}
	}

[clubby789]

Different shells can tab-complete a folder name with or without a trailing slash so hopefully this can handle both

[bors]

☔ The latest upstream changes (presumably #121400) made this pull request unmergeable. Please resolve the merge conflicts.

[onur-ozkan]

Thanks!

[onur-ozkan]

@bors r+

[bors]

📌 Commit eee5672 has been approved by onur-ozkan

It is now in the queue for this repository.

[klensy]

Nothing can go wrong with hardcoded paths.

[klensy]

Maybe collects folders in /tests at runtime and assert that lists equal (excluding auxiliary)?

[clubby789]

I'll follow this one up with a test

[klensy]

And now this list missing tests/crashes

[onur-ozkan]

We have a test for checking the existance paths. Seems like we need a test for missing paths too.

[onur-ozkan]

We have a test for checking the existance paths. Seems like we need a test for missing paths too.

Here it is: #124969

[bors]

⌛ Testing commit eee5672 with merge 933a05b...

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing 933a05b to master...

[rust-timer]

Finished benchmarking commit (933a05b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.076s -> 649.98s (0.14%)
Artifact size: 310.97 MiB -> 310.97 MiB (-0.00%)