Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #121295

Merged
merged 12 commits into from
Feb 19, 2024
Merged

Rollup of 6 pull requests #121295

merged 12 commits into from
Feb 19, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

oli-obk and others added 12 commits February 13, 2024 14:56
@oli-obk
Continue reporting remaining errors instead of silently dropping them
e9cda9b
@GnomedDev
Store core::str::CharSearcher::utf8_size as u8
601f2d1
@GuillaumeGomez
Extend Level API
c17539c
@pitaj
diagnostic items for legacy numeric constants
d9c1c73
@tshepang
add test for panicking attribute macros
9f614cb
@Noratrieb
Add Future and IntoFuture to the 2024 prelude
bd8a1a4 
Implements RFC 3509.
@matthiaskrgr
Rollup merge of rust-lang#119808 - GnomedDev:encode-charsearcher-size…
c5da038 
…-in-type, r=Mark-Simulacrum

Store core::str::CharSearcher::utf8_size as u8

This is already relied on being smaller than u8 due to the `safety invariant: utf8_size must be less than 5`, so this helps LLVM optimize and maybe improve copies due to padding instead of unused bytes.
@matthiaskrgr
Rollup merge of rust-lang#121032 - oli-obk:cyclic_type_ice, r=cjgillot
25bba60 
Continue reporting remaining errors instead of silently dropping them

I was too eager to add assertions in https://github.com/rust-lang/rust/pull/120342/files#diff-593003090e0fb5c21f31413ce5feb506e235ec33c4775da88b853980429b9ff1R741

fixes rust-lang#120864
@matthiaskrgr
Rollup merge of rust-lang#121041 - Nilstrieb:into-the-future-of-2024,…
cf0b36a 
… r=Mark-Simulacrum

Add `Future` and `IntoFuture` to the 2024 prelude

Implements rust-lang/rfcs#3509.
@matthiaskrgr
Rollup merge of rust-lang#121230 - GuillaumeGomez:extend-level-api, r…
ec07410 
…=Nadrieril

Extend Level API

I need this API for rust-lang/rust-clippy#12303: I have a nested `cfg` attribute (so a `MetaItem`) and I'd like to still be able to match against all possible kind of `Level`s.
@matthiaskrgr
Rollup merge of rust-lang#121272 - pitaj:diag_items-legacy_numeric_co…
c2cc066 
…nstants, r=Nilstrieb

Add diagnostic items for legacy numeric constants

For rust-lang/rust-clippy#12312
@matthiaskrgr
Rollup merge of rust-lang#121275 - tshepang:test-panicking-proc-macro…
3fe809b 
…s, r=nnethercote

add test for panicking attribute macros
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 19, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Feb 19, 2024

📌 Commit 3fe809b has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2024
@bors
Copy link
Contributor

bors commented Feb 19, 2024

⌛ Testing commit 3fe809b with merge e29a153...

@bors
Copy link
Contributor

bors commented Feb 19, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29a153 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 19, 2024
@bors bors merged commit e29a153 into rust-lang:master Feb 19, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 19, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119808 Store core::str::CharSearcher::utf8_size as u8 77ad625956859194b56f0544112d3a30ea4754b5 (link)
#121032 Continue reporting remaining errors instead of silently dro… 4fbeab8d8a46ed9b39952afeb659fc201e54c7dc (link)
#121041 Add Future and IntoFuture to the 2024 prelude 96f9387cdc0c57704ff753aad9831b9478621d53 (link)
#121230 Extend Level API b2cb8e184470372214c65ff9d6c081b2c5d98d53 (link)
#121272 Add diagnostic items for legacy numeric constants f5929b4915ea8cb6863a4b5cc4e021523c54a170 (link)
#121275 add test for panicking attribute macros cf16433e1bdc7c14f02478d8d9fbe99a2f95c39a (link)

previous master: 43d3470f11

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

This was referenced Feb 19, 2024
Open
Merged
This was referenced Feb 19, 2024
Open
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e29a153): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.0% [0.1%, 3.8%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.2% [-6.5%, -0.8%] 3
Improvements ✅
(secondary)		 -3.4% [-3.5%, -3.4%] 2
All ❌✅ (primary) -1.2% [-6.5%, 3.8%] 5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.1% [0.0%, 0.9%] 17
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.5%, -0.1%] 3
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.1% [-0.5%, 0.9%] 20

Bootstrap: 641.758s -> 640.759s (-0.16%)
Artifact size: 308.80 MiB -> 308.79 MiB (-0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-j2vffew branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
10 participants
@matthiaskrgr @bors @rust-timer @rustbot @oli-obk @GnomedDev @GuillaumeGomez @pitaj @tshepang @Noratrieb