Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Update LLVM submodule #121132

Closed
wants to merge 1 commit into from
Closed

[beta] Update LLVM submodule #121132

wants to merge 1 commit into from

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Feb 15, 2024

This backports a number of patches that were part of the LLVM 18 upgrade on master to LLVM 17 on the beta branch.

Fixes #119179.
Fixes #120260.
Fixes #120813.
Fixes #120268 (comment).

r? @cuviper

@rustbot
Copy link
Collaborator

rustbot commented Feb 15, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 15, 2024
@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 15, 2024
@matthiaskrgr matthiaskrgr changed the title Update LLVM submodule [beta] Update LLVM submodule Feb 15, 2024
@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 15, 2024
@cuviper cuviper mentioned this pull request Feb 15, 2024
Merged
cuviper
cuviper approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rolling this into #121069.

@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2024
@bors
Auto merge of rust-lang#121069 - cuviper:beta-next, r=cuviper
d783f37 
[beta] backports

- Correct paths for hexagon-unknown-none-elf platform doc rust-lang#120533
- CI: Use ninja on apple builders rust-lang#120543
- Correctly check `never_type` feature gating rust-lang#120552
- Revert unsound libcore changes of 119911 rust-lang#120562
- Downgrade xcode rust-lang#120914
- Update jobserver-rs to 0.1.28 rust-lang#120846
- [beta] Update LLVM submodule rust-lang#121132

r? cuviper
@cuviper
Copy link
Member

cuviper commented Feb 16, 2024

Done!

@cuviper cuviper closed this Feb 16, 2024
@cuviper cuviper added this to the 1.77.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper approved these changes

Assignees

@cuviper cuviper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nikic @rustbot @apiraino @cuviper