Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wording of static_mut_ref #121034

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Improve wording of static_mut_ref #121034

merged 1 commit into from
Feb 18, 2024

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Feb 13, 2024

Close #120964

@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 13, 2024
@compiler-errors
Copy link
Member

r? RalfJung

@rustbot rustbot assigned RalfJung and unassigned compiler-errors Feb 13, 2024
RalfJung
RalfJung reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I used the opportunity to update and refine the wording. Please also make the same changes in the lint as well.

compiler/rustc_error_codes/src/error_codes/E0796.md Outdated Show resolved Hide resolved
compiler/rustc_error_codes/src/error_codes/E0796.md Outdated Show resolved Hide resolved
compiler/rustc_error_codes/src/error_codes/E0796.md Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/errors.rs Outdated Show resolved Hide resolved
@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2024

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 14, 2024
RalfJung
RalfJung reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language tweaks are getting smaller. :)

compiler/rustc_error_codes/src/error_codes/E0796.md Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
tests/ui/abi/statics/static-mut-foreign.stderr Outdated Show resolved Hide resolved
tests/ui/static/reference-to-mut-static-safe.e2024.stderr Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/check/errs.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@apiraino
Copy link
Contributor

Beta backport reviewed and postponed to next week. Let's wait first how the review proceeds, ideally before approving the backport we would like to see this PR to get the greenlight for merge discussion on Zulip.

@RalfJung
Copy link
Member

Looks good, thanks. :)
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 15, 2024

📌 Commit b277772 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 15, 2024
@GuillaumeGomez
Rollup merge of rust-lang#121034 - obeis:improve-static-mut-ref, r=Ra…
3f90669 
…lfJung

Improve wording of `static_mut_ref`

Close rust-lang#120964
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 15, 2024
Closed
oli-obk added a commit to oli-obk/rust that referenced this pull request Feb 15, 2024
@oli-obk
Rollup merge of rust-lang#121034 - obeis:improve-static-mut-ref, r=Ra…
0baee2a 
…lfJung

Improve wording of `static_mut_ref`

Close rust-lang#120964
@oli-obk oli-obk mentioned this pull request Feb 15, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2024
@bors
Auto merge of rust-lang#121158 - GuillaumeGomez:rollup-l38pzjw, r=Gui…
204a1dd 
…llaumeGomez

Rollup of 13 pull requests

Successful merges:

 - rust-lang#118264 (Optimize `VecDeque::drain` for (half-)open ranges)
 - rust-lang#120741 (Make `io::BorrowedCursor::advance` safe)
 - rust-lang#120777 (Bump Unicode to version 15.1.0, regenerate tables)
 - rust-lang#120971 (Fix comment in core/src/str/validations.rs)
 - rust-lang#121034 (Improve wording of `static_mut_ref`)
 - rust-lang#121095 (Add extra indent spaces for rust-playground link)
 - rust-lang#121109 (Add an ErrorGuaranteed to ast::TyKind::Err (attempt 2))
 - rust-lang#121119 (Make `async Fn` trait kind errors better)
 - rust-lang#121141 (Fix closure kind docs)
 - rust-lang#121145 (Update aarch64 target feature docs to match LLVM)
 - rust-lang#121146 (Only point out non-diverging arms for match suggestions)
 - rust-lang#121147 (Avoid debug logging entire MIR body)
 - rust-lang#121155 (doc: add note about panicking examples for strict_overflow_ops)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis
Improve wording of static_mut_ref
408eeae 
Rename `static_mut_ref` lint to `static_mut_refs`.
@obeis
Copy link
Contributor Author

obeis commented Feb 18, 2024

@bors r=@RalfJung

@bors
Copy link
Contributor

bors commented Feb 18, 2024

📌 Commit 408eeae has been approved by RalfJung

It is now in the queue for this repository.

CKingX added a commit to CKingX/rust that referenced this pull request Feb 18, 2024
@CKingX
Rollup merge of rust-lang#121034 - obeis:improve-static-mut-ref, r=Ra…
c465cfa 
…lfJung

Improve wording of `static_mut_ref`

Close rust-lang#120964
@CKingX CKingX mentioned this pull request Feb 18, 2024
Closed
@bors
Copy link
Contributor

bors commented Feb 18, 2024

⌛ Testing commit 408eeae with merge bcb3545...

@bors
Copy link
Contributor

bors commented Feb 18, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing bcb3545 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 18, 2024
@bors bors merged commit bcb3545 into rust-lang:master Feb 18, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bcb3545): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.4% [0.4%, 0.4%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.9% [1.3%, 2.8%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 640.08s -> 639.843s (-0.04%)
Artifact size: 308.75 MiB -> 308.82 MiB (0.02%)

@obeis obeis deleted the improve-static-mut-ref branch February 20, 2024 07:39
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request Feb 21, 2024
@bors
Auto merge of rust-lang#121034 - obeis:improve-static-mut-ref, r=Ralf…
c350ae8 
…Jung

Improve wording of `static_mut_ref`

Close rust-lang#120964
@apiraino
Copy link
Contributor

apiraino commented Feb 22, 2024 •
edited
Loading

Beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 22, 2024
@RalfJung
Copy link
Member

I have to ask this each time because I forget, sorry.^^ What is the process now, who's responsible for creating the beta PR? (Maybe that info could be included in the standard approval message. :D )

@compiler-errors
Copy link
Member

compiler-errors commented Feb 22, 2024 •
edited
Loading

T-release will do it

(Maybe that info could be included in the standard approval message. :D )

👍

@ehuss ehuss mentioned this pull request Feb 24, 2024
Merged
@Urgau Urgau mentioned this pull request Mar 1, 2024
Merged
@cuviper cuviper mentioned this pull request Mar 4, 2024
Merged
@cuviper cuviper modified the milestones: 1.78.0, 1.77.0 Mar 4, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2024
@bors
Auto merge of rust-lang#121984 - cuviper:beta-next, r=cuviper
339fb69 
[beta] backports

- Improve wording of `static_mut_ref` rust-lang#121034
- Solaris linker does not support --strip-debug rust-lang#121399

r? cuviper
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Mar 8, 2024
@bors
Auto merge of rust-lang#121034 - obeis:improve-static-mut-ref, r=Ralf…
4f23c24 
…Jung

Improve wording of `static_mut_ref`

Close rust-lang#120964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riking riking riking left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees

@RalfJung RalfJung

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

Improve wording of static_mut_ref