Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve write_fmt to handle simple strings #121001

Merged
merged 7 commits into from
Mar 5, 2024
Merged

perf: improve write_fmt to handle simple strings #121001

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d712e3f
perf: improve write_fmt to handle simple strings
nyurik Feb 13, 2024
6fa7d6c
Use intrinsic
nyurik Feb 14, 2024
c50779f
Fix inlining issue for non-const case
nyurik Feb 14, 2024
377594d
add safety text
nyurik Feb 14, 2024
8362b30
remove const
nyurik Feb 15, 2024
1eee9f5
A much simpler version of write
nyurik Feb 15, 2024
c85a9df
fix doc link
nyurik Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions library/core/src/fmt/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,8 +1102,14 @@ pub trait UpperExp {
/// ```
///
/// [`write!`]: crate::write!
#[inline]
#[stable(feature = "rust1", since = "1.0.0")]
pub fn write(output: &mut dyn Write, args: Arguments<'_>) -> Result {
if let Some(s) = args.as_str() { output.write_str(s) } else { write_internal(output, args) }
}

/// Actual implementation of the [`write()`], but without the simple string optimization.
fn write_internal(output: &mut dyn Write, args: Arguments<'_>) -> Result {
let mut formatter = Formatter::new(output);
let mut idx = 0;

Expand Down
Loading