-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci update freebsd version proposal, freebsd 12 being eol #120869
base: master
Are you sure you want to change the base?
Conversation
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
Does this mean that the minimum supported version is raised? Or is freebsd backwards-compatible so that builds against a new version still run on the old versiom? (A thing that's, for example, not true for linux glibc). |
6123e25
to
4008e0e
Compare
@rustbot author Please update the PR description with details that @Nilstrieb asked for. It would probably also be a good idea to reflect in the platform support page (https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support.md) the target details if this does raise the minimum, so that users have something to reference for future Rust versions. |
4008e0e
to
a8a6822
Compare
@rustbot review |
What is the current minimum freebsd version supported by rustc? The platform support doc page doesn't document this. |
I would say freebsd 12. |
Thank you for adding it! Not in this PR, but it would be nice if you could add a new target documentation page in I just looked it up, the last FreeBSD bump was #97944. It didn't include a blog post (which we do for bumps of more popular targets), so that seems fine. It superseded #89083 which contains more information. Looks like we use FreeBSD artifacts on our CI mirror, so @Mark-Simulacrum (or someone else with permissions) will have to upload them first before this can be merged. |
I've put the artifacts in our mirror (2024-02-18-freebsd-13.2-i386-base.txz and 2024-02-18-freebsd-13.2-amd64-base.txz). Please update the download file to match those, and then we can move ahead. |
c7285bd
to
42d5b87
Compare
@rustbot review |
@bors r+ rollup=iffy |
🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened. |
ping :) any luck ? unfortunately, it blocks further freebsd updates. |
☔ The latest upstream changes (presumably #121712) made this pull request unmergeable. Please resolve the merge conflicts. |
26a4230
to
c01b042
Compare
☔ The latest upstream changes (presumably #124404) made this pull request unmergeable. Please resolve the merge conflicts. |
I interpret this as That said, above you were asked to add some background and explanation to the PR description, which apparently has not happened yet. |
I don't know where that clang version is coming from. In general our dist builders often use older toolchains installed from e.g. Ubuntu LTS versions, if we need to build our own copy of clang that should generally be fine to add (see e.g. https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/dist-x86_64-linux/build-clang.sh).
Yeah, this would still be good to do. @rustbot author I don't think this is ready for another round of CI (unless I missed something), so setting back to waiting on author. I easily miss pings so would recommend setting to waiting-on-review as Ralf did if you need reviewer attention. |
Sure but problem is, llvm would not compile with clang 6 ?
I ve done it. |
Some changes occurred in src/tools/cargo cc @ehuss |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #128461) made this pull request unmergeable. Please resolve the merge conflicts. |
@devnexen |
yes the build for freebsd need to be updated. |
@devnexen thanks, where we can track it update? |
It might be best to create an issue because it s complicated, it s using docker to build freebsd binaries with an old toolchain. Ideally, something like cirrus would be more ideal. |
Issue opened here. |
raising to the lowest still active supported freebsd version. From 13.1 (already eol too), freebsd introduces a cpu affinity layer with linux. It also introduces a api compatible copy_file_range which can be used like its linux's counterpart. The former is essential to build rust-lang#120589, therefore breaks the backward compatibility with the previous FreeBSD releases.
aa6c298
to
65f05af
Compare
@Mark-Simulacrum would it be possible to give another try ? since I ve updated the Docker container version, it should come with a newer clang version. |
raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build #120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.
Blocked on #130465