coverage: Flatten the functions for extracting/refining coverage spans #120294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidating this code into flatter functions reduces the amount of pointer-chasing required to read and modify it.
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
the
A-code-coverage
|
Hmm, I should probably just combine these two into one double-refactoring PR, to save the hassle of an extra conflict-resolution step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidating this code into flatter functions reduces the amount of pointer-chasing required to read and modify it.
No functional changes.
Ignoring whitespace is recommended, as it shows that most of the moved code has not been modified.
This has a trivial conflict with #120292 (renamed function called by re-indented code), so when one merges, the other will require a tiny fixup.
@rustbot label +A-code-coverage