[beta] Revert trait obj upcast stabilization #120269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
revert_trait_obj_upcast_stabilization
branch
from
83de3cb
to
9bc7360
Compare
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
revert_trait_obj_upcast_stabilization
branch
from
9bc7360
to
3a638f7
Compare
|
@bors r=jackh726 |
bors
added
S-waiting-on-bors
|
@bors rollup=never |
|
@bors p=1 let's land this as early as possible before the stable cut |
|
@bors p=20 to jump ahead of the next rollup and since this fixes a P-critical soundness issue. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2024
…ilization, r=jackh726 [beta] Revert trait obj upcast stabilization backport of rust-lang#120233 note that this is not yet approved for beta backport
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry timeout |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 12, 2024
…k-Simulacrum [Beta 1.77] Fix bootstrapping from 1.76 Due to the timing of the revert for stabilization of c_str_literal (rust-lang#119528 which reverted in 1.76) and trait_upcasting (rust-lang#120269 which reverted in 1.76), which happened after rust-lang#119211 (Bump stage0 to 1.76 beta), this resulted in some of the feature attributes not being restored which are needed to be able to bootstrap from 1.76. This restores those features. This also includes a stage0 bump to the just released stable. This is necessary because stage0 was currently pointing at an old beta which did not contain the reverts. Fixes rust-lang#120810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #120233
note that this is not yet approved for beta backport