Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #120251

Merged
merged 21 commits into from
Jan 23, 2024
Merged
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f2ef88b
Consolidate logic around resolving built-in coroutine trait impls
compiler-errors Jan 19, 2024
c3e4c45
Track `verbose` and `verbose_internals`
jyn514 Jan 19, 2024
012a304
Fix a `trimmed_def_paths` assertion failure.
nnethercote Jan 22, 2024
c4fc9ff
Document `Token{Stream,Tree}::Display` more thoroughly.
nnethercote Jan 22, 2024
e74c667
Fix msys2 tty detection for /dev/ptmx
ChrisDenton Jan 6, 2024
dbc1f07
Tweak
Nadrieril Jan 18, 2024
a9ea07d
Never pattern in function arguments diverges
Nadrieril Jan 18, 2024
d1f1075
Never pattern in `let` statement diverges
Nadrieril Jan 18, 2024
9a20cf1
Revert "Auto merge of #118133 - Urgau:stabilize_trait_upcasting, r=Wa…
oli-obk Jan 22, 2024
483382b
Add regression test
oli-obk Jan 22, 2024
f88e643
std: move cmath into `sys`
joboet Jan 18, 2024
c5a4e07
Use `-> !` to test divergence
Nadrieril Jan 22, 2024
3ff1024
Test async fn
Nadrieril Jan 18, 2024
67d0936
Rollup merge of #119664 - ChrisDenton:mingw-pty, r=thomcc
matthiaskrgr Jan 22, 2024
042cc72
Rollup merge of #120104 - Nadrieril:never-pat-diverges, r=compiler-er…
matthiaskrgr Jan 22, 2024
42e1db5
Rollup merge of #120109 - joboet:move_pal_cmath, r=ChrisDenton
matthiaskrgr Jan 22, 2024
221115c
Rollup merge of #120143 - compiler-errors:consolidate-instance-resolv…
matthiaskrgr Jan 22, 2024
8966d60
Rollup merge of #120159 - jyn514:track-verbose, r=wesleywiser
matthiaskrgr Jan 22, 2024
31b56a8
Rollup merge of #120216 - nnethercote:fix-trimmed_def_paths-assertion…
matthiaskrgr Jan 22, 2024
a430718
Rollup merge of #120220 - nnethercote:TokenStream-Display-docs, r=pet…
matthiaskrgr Jan 22, 2024
a787232
Rollup merge of #120233 - oli-obk:revert_trait_obj_upcast_stabilizati…
matthiaskrgr Jan 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions library/std/src/sys/pal/windows/io.rs
Original file line number Diff line number Diff line change
@@ -97,20 +97,6 @@ unsafe fn handle_is_console(handle: BorrowedHandle<'_>) -> bool {
return true;
}

// At this point, we *could* have a false negative. We can determine that this is a true
// negative if we can detect the presence of a console on any of the standard I/O streams. If
// another stream has a console, then we know we're in a Windows console and can therefore
// trust the negative.
for std_handle in [c::STD_INPUT_HANDLE, c::STD_OUTPUT_HANDLE, c::STD_ERROR_HANDLE] {
let std_handle = c::GetStdHandle(std_handle);
if !std_handle.is_null()
&& std_handle != handle
&& c::GetConsoleMode(std_handle, &mut out) != 0
{
return false;
}
}

// Otherwise, we fall back to an msys hack to see if we can detect the presence of a pty.
msys_tty_on(handle)
}