Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Static Builds for FreeBSD #119855

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Enable Static Builds for FreeBSD #119855

merged 1 commit into from
Jan 18, 2024
+8 −1

Conversation

rellerreller
Copy link

Enable crt-static for FreeBSD to enable statically compiled binaries.

@rellerreller
Enable Static Builds for FreeBSD
adce3fd 
Enable crt-static for FreeBSD to enable statically compiled binaries.
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@cjgillot
Copy link
Contributor

r? compiler

@rustbot rustbot assigned wesleywiser and unassigned cjgillot Jan 11, 2024
@rellerreller
Copy link
Author

Please let me know if you have any question. I would be happy to answer them.

wesleywiser
wesleywiser approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look correct to me but I don't use FreeBSD and don't have any systems to test on. Have you tested building some small Rust programs with both static and dynamic linking to validate these changes?

@rellerreller
Copy link
Author

Yes, I have validated both static and dynamic linking on a FreeBSD system. I can attach some terminal output if you like to show the libraries that are linked. Just let me know.

@wesleywiser
Copy link
Member

No, that's fine! Just wanted to make sure both cases were tested. Thanks! 🙂

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 16, 2024

📌 Commit adce3fd has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2024
@matthiaskrgr
Rollup merge of rust-lang#119855 - rellerreller:freebsd-static, r=wes…
8512296 
…leywiser

Enable Static Builds for FreeBSD

Enable crt-static for FreeBSD to enable statically compiled binaries.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 16, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120034 - matthiaskrgr:rollup-dr3hbb2, r=matth…
06f315f 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119922 (Rework how diagnostic lints are stored.)
 - rust-lang#119978 (Move async closure parameters into the resultant closure's future eagerly)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120021 (don't store const var origins for known vars)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)

r? `@ghost`
`@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 17, 2024
@compiler-errors
Rollup merge of rust-lang#119855 - rellerreller:freebsd-static, r=wes…
f2a74e2 
…leywiser

Enable Static Builds for FreeBSD

Enable crt-static for FreeBSD to enable statically compiled binaries.
@compiler-errors compiler-errors mentioned this pull request Jan 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120041 - compiler-errors:rollup-bejv6ch, r=co…
650e124 
…mpiler-errors

Rollup of 9 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119651 (proc_macro: Add Literal::c_string constructor)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119955 (Modify GenericArg and Term structs to use strict provenance rules)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120034 - matthiaskrgr:rollup-dr3hbb2, r=matth…
05c0a04 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119922 (Rework how diagnostic lints are stored.)
 - rust-lang#119978 (Move async closure parameters into the resultant closure's future eagerly)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120021 (don't store const var origins for known vars)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 17, 2024
@matthiaskrgr
Rollup merge of rust-lang#119855 - rellerreller:freebsd-static, r=wes…
c533a26 
…leywiser

Enable Static Builds for FreeBSD

Enable crt-static for FreeBSD to enable statically compiled binaries.
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120064 - matthiaskrgr:rollup-we5zgxg, r=matth…
e649aef 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#119984 (Change return type of unstable `Waker::noop()` from `Waker` to `&Waker`.)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 17, 2024
@compiler-errors
Rollup merge of rust-lang#119855 - rellerreller:freebsd-static, r=wes…
9d094bb 
…leywiser

Enable Static Builds for FreeBSD

Enable crt-static for FreeBSD to enable statically compiled binaries.
@compiler-errors compiler-errors mentioned this pull request Jan 17, 2024
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2024
Merged
@rellerreller
Copy link
Author

Please let me know if there is anything else that I need to do. I don't know how to interpret the output from bors or what to expect next.
When would this patch be merged?

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2024
@bors
Auto merge of rust-lang#120068 - matthiaskrgr:rollup-vxugut5, r=matth…
ef72d25 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@bors
Auto merge of rust-lang#120068 - matthiaskrgr:rollup-vxugut5, r=matth…
2457c02 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#115291 (Save liveness results for DestinationPropagation)
 - rust-lang#119855 (Enable Static Builds for FreeBSD)
 - rust-lang#119975 (Don't ICE if TAIT-defining fn contains a closure with `_` in return type)
 - rust-lang#120001 (Consistently unset RUSTC_BOOTSTRAP when compiling bootstrap)
 - rust-lang#120020 (Gracefully handle missing typeck information if typeck errored)
 - rust-lang#120031 (Construct closure type eagerly)
 - rust-lang#120032 (Fix `rustc_abi` build on stable)
 - rust-lang#120039 (pat_analysis: Don't rely on contiguous `VariantId`s outside of rustc)
 - rust-lang#120044 (Fix typo in comments (in_place_collect))
 - rust-lang#120056 (Use FnOnceOutput instead of FnOnce where expected)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c9779af into rust-lang:master Jan 18, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@rust-timer
Unrolled build for rust-lang#119855
574d158 
Rollup merge of rust-lang#119855 - rellerreller:freebsd-static, r=wesleywiser

Enable Static Builds for FreeBSD

Enable crt-static for FreeBSD to enable statically compiled binaries.
@wesleywiser
Copy link
Member

@rellerreller This got merged last night so you don't need to do anything else. If you're interested, you can see the bors queue here. If any issues are found with your changes during the bors build, it will leave a comment here with a link to the failing build log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rellerreller @rustbot @cjgillot @wesleywiser @bors