Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split tait and impl trait in assoc items logic #119766

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Split tait and impl trait in assoc items logic #119766

merged 6 commits into from
Jan 24, 2024

Commits on Jan 22, 2024

  1. Add a simpler and more targetted code path for impl trait in assoc items

    @oli-obk
    oli-obk committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f58af9b View commit details
    Browse the repository at this point in the history

  2. Pull opaque type check into a separate method

    @oli-obk
    oli-obk committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ac332bd View commit details
    Browse the repository at this point in the history

  3. Limit impl trait in assoc type defining scope

    @oli-obk
    oli-obk committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f75361f View commit details
    Browse the repository at this point in the history

  4. Add some tests

    @oli-obk
    oli-obk committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4e07699 View commit details
    Browse the repository at this point in the history

  5. Use an enum instead of a bool

    @oli-obk
    oli-obk committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1829aa6 View commit details
    Browse the repository at this point in the history

  6. Check that we forbid nested items, but not nested closures

    @oli-obk
    oli-obk committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5e5d135 View commit details
    Browse the repository at this point in the history