Rollup of 6 pull requests #119680

compiler-errors · 2024-01-07T02:51:48Z

Successful merges:

rustc_mir_transform: Enforce rustc::potential_query_instability lint #119252 (rustc_mir_transform: Enforce rustc::potential_query_instability lint)
Use the current target instead of iterating over all targets #119548 (Use the current target instead of iterating over all targets)
document rounding behavior of rint/nearbyint for ties #119656 (document rounding behavior of rint/nearbyint for ties)
Fix typo in docs for slice::split_once, slice::rsplit_once #119657 (Fix typo in docs for slice::split_once, slice::rsplit_once)
Populate yield and resume types in MIR body while body is being initialized #119666 (Populate yield and resume types in MIR body while body is being initialized)
Ask for rustc version in diagnostic reports, remind users to update their toolchain #119679 (Ask for rustc version in diagnostic reports, remind users to update their toolchain)

r? @ghost
@rustbot modify labels: rollup

Since we already iterate through targets in StepDescription::maybe_run, there is no need to iterate targets again in the install step for std. Compared the results before and after applying the changes to install step of std, and there were no differences. ```sh  ~/devspace/.other/rustc-builds $ sha256sum ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-* c2ea86fc25ffac87b0b135f31ba9644ad97549da4c050c3921b437d1e18285fd ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-pc-windows-gnu d2f1081a779962e2cbc27f53191783d13428abd0964465547af78ce34c7251dd ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-unknown-linux-gnu  ~/devspace/.other/rustc-builds $ sha256sum ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-* c2ea86fc25ffac87b0b135f31ba9644ad97549da4c050c3921b437d1e18285fd ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-pc-windows-gnu d2f1081a779962e2cbc27f53191783d13428abd0964465547af78ce34c7251dd ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-unknown-linux-gnu ``` Signed-off-by: onur-ozkan <[email protected]>

Stop allowing `rustc::potential_query_instability` on all of rustc_mir_transform and instead allow it on a case-by-case basis if it is safe to do so. In this particular crate, all instances were safe to allow.

…heir toolchain

…stability, r=cjgillot rustc_mir_transform: Enforce `rustc::potential_query_instability` lint Stop allowing `rustc::potential_query_instability` on all of rustc_mir_transform and instead allow it on a case-by-case basis if it is safe to do so. In this particular crate, all instances were safe to allow. Part of rust-lang#84447 which is E-help-wanted.

…eration, r=Mark-Simulacrum Use the current target instead of iterating over all targets Since we already iterate through targets in StepDescription::maybe_run, there is no need to iterate targets again in the install step for std. Compared the results before and after applying the changes to install step of std, and there were no differences. ```sh  ~/devspace/.other/rustc-builds $ sha256sum ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-* c2ea86fc25ffac87b0b135f31ba9644ad97549da4c050c3921b437d1e18285fd ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-pc-windows-gnu d2f1081a779962e2cbc27f53191783d13428abd0964465547af78ce34c7251dd ./old/usr/local/lib/rustlib/manifest-rust-std-x86_64-unknown-linux-gnu  ~/devspace/.other/rustc-builds $ sha256sum ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-* c2ea86fc25ffac87b0b135f31ba9644ad97549da4c050c3921b437d1e18285fd ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-pc-windows-gnu d2f1081a779962e2cbc27f53191783d13428abd0964465547af78ce34c7251dd ./new/usr/local/lib/rustlib/manifest-rust-std-x86_64-unknown-linux-gnu ``` Fixes rust-lang#119533

…crum document rounding behavior of rint/nearbyint for ties It's not possible to change the rounding mode in Rust, so these intrinsics will always behave like `roundeven`.

…Denton Fix typo in docs for slice::split_once, slice::rsplit_once This fixes a typo in the doc comments for these methods, which I tripped over while reading the docs: "If any matching elements are **resent** in the slice [...]", which is presumably meant to read **present**. I mentioned this in rust-lang#112811, the tracking issue for `slice_split_once`, and was encouraged to open a PR.

…e-info-immediately, r=cjgillot Populate `yield` and `resume` types in MIR body while body is being initialized I found it weird that we went back and populated these types *after* the body was constructed. Let's just do it all at once.

…=Mark-Simulacrum Ask for rustc version in diagnostic reports, remind users to update their toolchain IDK why we don't ask for rustc toolchain when filing diagnostic issues. Diagnostics are sometimes very dramatically affected by compiler version, and users may report old diagnostic issues that were fixed by subsequent rustc versions that they have yet to update to. For example, rust-lang#119678 was made a bit more difficult to triage due to the template not asking the issuer to report their rustc version.

compiler-errors · 2024-01-07T02:51:58Z

@bors r+ rollup=never p=6

bors · 2024-01-07T02:52:01Z

📌 Commit 79475c0 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2024-01-07T02:55:47Z

⌛ Testing commit 79475c0 with merge d9301e9...

…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#119252 (rustc_mir_transform: Enforce `rustc::potential_query_instability` lint) - rust-lang#119548 (Use the current target instead of iterating over all targets) - rust-lang#119656 (document rounding behavior of rint/nearbyint for ties) - rust-lang#119657 (Fix typo in docs for slice::split_once, slice::rsplit_once) - rust-lang#119666 (Populate `yield` and `resume` types in MIR body while body is being initialized) - rust-lang#119679 (Ask for rustc version in diagnostic reports, remind users to update their toolchain) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-07T07:10:47Z

💥 Test timed out

compiler-errors · 2024-01-07T07:13:31Z

@bors retry

bors · 2024-01-07T07:14:41Z

⌛ Testing commit 79475c0 with merge 6f4af9c...

rust-log-analyzer · 2024-01-07T07:15:14Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-01-07T09:12:23Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 6f4af9c to master...

rust-timer · 2024-01-07T09:14:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#119252	rustc_mir_transform: Enforce `rustc::potential_query_instab…	`98085c5bca5420f7d729690bdc7f21c8e8a81e44` (link)
#119548	Use the current target instead of iterating over all targets	`a58dbe9dabd15e91e4e21b639ff401c7ac9baf2e` (link)
#119656	document rounding behavior of rint/nearbyint for ties	`6bc5983b3fd6e04dd4274ca28b5eea0d12b98d0b` (link)
#119657	Fix typo in docs for slice::split_once, slice::rsplit_once	`84549f50d893760d5037be31677839e94a1de0c5` (link)
#119666	Populate `yield` and `resume` types in MIR body while body …	`bcefa3dc28b4c508f994f6fa33ebbf5d3fa48593` (link)
#119679	Ask for rustc version in diagnostic reports, remind users t…	`9fa34e6b694271b0c2ec174bfcf6a38ae7510626` (link)

previous master: 78c988fe3e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-01-07T10:32:51Z

Finished benchmarking commit (6f4af9c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	10.8%	[10.8%, 10.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.535s -> 667.475s (0.14%)
Artifact size: 308.52 MiB -> 308.53 MiB (0.00%)

onur-ozkan and others added 12 commits January 3, 2024 17:57

Fix typo in docs for slice::split_once, slice::rsplit_once

099b15f

document rounding behavior of rint/nearbyint for ties

96acaff

Don't populate yield and resume types after the fact

5e2b66f

rustc_mir_transform: Enforce rustc::potential_query_instability lint

6d8fb57

Stop allowing `rustc::potential_query_instability` on all of rustc_mir_transform and instead allow it on a case-by-case basis if it is safe to do so. In this particular crate, all instances were safe to allow.

Ask for rustc version in diagnostic reports, remind users to update t…

373aeed

…heir toolchain

Rollup merge of rust-lang#119656 - RalfJung:round-docs, r=Mark-Simula…

e63a32e

…crum document rounding behavior of rint/nearbyint for ties It's not possible to change the rounding mode in Rust, so these intrinsics will always behave like `roundeven`.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 7, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 7, 2024

bors merged commit 6f4af9c into rust-lang:master Jan 7, 2024
12 checks passed

rustbot added this to the 1.77.0 milestone Jan 7, 2024

This was referenced Jan 7, 2024

Draft of branch coverage support #118305

Closed

Simplify implementation of MIR promotion #119668

Merged

compiler-errors deleted the rollup-1kvfehl branch January 7, 2024 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #119680

Rollup of 6 pull requests #119680

compiler-errors commented Jan 7, 2024

compiler-errors commented Jan 7, 2024

bors commented Jan 7, 2024

bors commented Jan 7, 2024

bors commented Jan 7, 2024

compiler-errors commented Jan 7, 2024

bors commented Jan 7, 2024

rust-log-analyzer commented Jan 7, 2024

bors commented Jan 7, 2024

rust-timer commented Jan 7, 2024

rust-timer commented Jan 7, 2024

Rollup of 6 pull requests #119680

Rollup of 6 pull requests #119680

Conversation

compiler-errors commented Jan 7, 2024

compiler-errors commented Jan 7, 2024

bors commented Jan 7, 2024

bors commented Jan 7, 2024

bors commented Jan 7, 2024

compiler-errors commented Jan 7, 2024

bors commented Jan 7, 2024

rust-log-analyzer commented Jan 7, 2024

bors commented Jan 7, 2024

rust-timer commented Jan 7, 2024

rust-timer commented Jan 7, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size