Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #119671

Closed
wants to merge 7 commits into from
Closed

Rollup of 3 pull requests #119671

wants to merge 7 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

onur-ozkan and others added 7 commits January 6, 2024 14:05
@onur-ozkan
bump bootstrap dependencies
6705b5c 
Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan
bless tidy
4039a46 
Signed-off-by: onur-ozkan <[email protected]>
@cls
Fix typo in docs for slice::split_once, slice::rsplit_once
099b15f
@RalfJung
document rounding behavior of rint/nearbyint for ties
96acaff
@matthiaskrgr
Rollup merge of rust-lang#119654 - onur-ozkan:bump-dependencies, r=cl…
3465215 
…ubby789

bump bootstrap dependencies

This PR removes hard-coded patch versions, updates bootstrap's dependency stack to recent versions (some of the versions were released 3-4 years ago), and removes a few dependencies from bootstrap.

Removed dependencies:

![image](https://github.com/rust-lang/rust/assets/39852038/95e86325-aea0-4055-bee5-245c144f662e)
@matthiaskrgr
Rollup merge of rust-lang#119656 - RalfJung:round-docs, r=Mark-Simula…
67a10bf 
…crum

document rounding behavior of rint/nearbyint for ties

It's not possible to change the rounding mode in Rust, so these intrinsics will always behave like `roundeven`.
@matthiaskrgr
Rollup merge of rust-lang#119657 - cls:slice_split_once-typo, r=Chris…
c6a7dce 
…Denton

Fix typo in docs for slice::split_once, slice::rsplit_once

This fixes a typo in the doc comments for these methods, which I tripped over while reading the docs: "If any matching elements are **resent** in the slice [...]", which is presumably meant to read **present**.

I mentioned this in rust-lang#112811, the tracking issue for `slice_split_once`, and was encouraged to open a PR.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 6, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Jan 6, 2024

📌 Commit c6a7dce has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2024
@bors
Copy link
Contributor

bors commented Jan 6, 2024

⌛ Testing commit c6a7dce with merge 9d623d2...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2024
@bors
Auto merge of rust-lang#119671 - matthiaskrgr:rollup-13vxv34, r=matth…
9d623d2 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119654 (bump bootstrap dependencies)
 - rust-lang#119656 (document rounding behavior of rint/nearbyint for ties)
 - rust-lang#119657 (Fix typo in docs for slice::split_once, slice::rsplit_once)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jan 6, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-integration failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
running: "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "/checkout/src/llvm-project/libunwind/include" "-nostdinc++" "-fno-exceptions" "-fno-rtti" "-fstrict-aliasing" "-funwind-tables" "-fvisibility=hidden" "-std=c++11" "-D_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/376c923bd8cbe952-Unwind-seh.o" "-c" "/checkout/src/llvm-project/libunwind/src/Unwind-seh.cpp"
exit status: 0
running: "c++" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "/checkout/src/llvm-project/libunwind/include" "-nostdinc++" "-fno-exceptions" "-fno-rtti" "-fstrict-aliasing" "-funwind-tables" "-fvisibility=hidden" "-std=c++11" "-D_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/376c923bd8cbe952-libunwind.o" "-c" "/checkout/src/llvm-project/libunwind/src/libunwind.cpp"
exit status: 0
running: ZERO_AR_DATE="1" "ar" "cq" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/libunwind-cpp.a" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/376c923bd8cbe952-Unwind-EHABI.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/376c923bd8cbe952-Unwind-seh.o" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/376c923bd8cbe952-libunwind.o"
running: "ar" "s" "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind/libunwind-cpp.a"
exit status: 0
thread 'main' panicked at src/core/build_steps/llvm.rs:1370:9:
thread 'main' panicked at src/core/build_steps/llvm.rs:1370:9:
assertion `left == right` failed: Can't get object files from "/checkout/obj/build/x86_64-unknown-linux-gnu/native/libunwind"
 right: 0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
##[endgroup]
Build completed unsuccessfully in 0:00:17

@onur-ozkan onur-ozkan mentioned this pull request Jan 7, 2024
Merged
@matthiaskrgr matthiaskrgr deleted the rollup-13vxv34 branch March 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthiaskrgr @bors @rust-log-analyzer @rustbot @onur-ozkan @cls @RalfJung