Update to bitflags 2 in the compiler #119446
Conversation
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
|
I meant to r? compiler-errors |
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
bitflags2.0-hell
branch
from
2cb6969
to
8047b6c
Compare
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
| @@ -150,3 +150,14 @@ pub fn make_display(f: impl Fn(&mut fmt::Formatter<'_>) -> fmt::Result) -> impl | |||
| // See comments in src/librustc_middle/lib.rs | |||
| #[doc(hidden)] | |||
| pub fn __noop_fix_for_27438() {} | |||
There was a problem hiding this comment.
__noop_fix_for_27438
what the heck is this
There was a problem hiding this comment.
good solutions for good problems (some windows shared library shenanigans apparently?)
This comment has been minimized.
This comment has been minimized.
Noratrieb
force-pushed
the
bitflags2.0-hell
branch
from
8047b6c
to
8743bca
Compare
This comment has been minimized.
This comment has been minimized.
This involves lots of breaking changes. There are two big changes that force changes. The first is that the bitflag types now don't automatically implement normal derive traits, so we need to derive them manually. Additionally, bitflags now have a hidden inner type by default, which breaks our custom derives. The bitflags docs recommend using the impl form in these cases, which I did.
Noratrieb
force-pushed
the
bitflags2.0-hell
branch
from
8743bca
to
ffafcd8
Compare
|
r=me |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (5a345b3): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 668.901s -> 669.431s (0.08%) |
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
Rollup merge of rust-lang#120032 - Nadrieril:fix-rustc_abi, r=Nilstrieb Fix `rustc_abi` build on stable rust-lang#119446 broke the ability of `rustc_abi` to build on stable, which is required by rust-analyzer. This fixes it.
This involves lots of breaking changes. There are two big changes that force changes. The first is that the bitflag types now don't automatically implement normal derive traits, so we need to derive them manually.
Additionally, bitflags now have a hidden inner type by default, which breaks our custom derives. The bitflags docs recommend using the impl form in these cases, which I did.
r? compiler