Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for --env compilation flag #119115

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

GuillaumeGomez
Copy link
Member

Part of #80792.
As mentioned in #118830.

It adds a mention to tracked_env::var and also clarifies what triggers a new compilation.

r? @Nilstrieb

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2023
@GuillaumeGomez
Copy link
Member Author

Updated!

Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@GuillaumeGomez
Copy link
Member Author

@bors r=Nilstrieb rollup

@bors
Copy link
Contributor

bors commented Dec 20, 2023

📌 Commit 2679bca has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2023
…llaumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119115 (Update documentation for `--env` compilation flag)
 - rust-lang#119155 (coverage: Check for `async fn` explicitly, without needing a heuristic)
 - rust-lang#119159 (Update LLVM submodule)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0bbcdb2 into rust-lang:master Dec 20, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 20, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2023
Rollup merge of rust-lang#119115 - GuillaumeGomez:env-docs, r=Nilstrieb

Update documentation for `--env` compilation flag

Part of rust-lang#80792.
As mentioned in rust-lang#118830.

It adds a mention to `tracked_env::var` and also clarifies what triggers a new compilation.

r? `@Nilstrieb`
@GuillaumeGomez GuillaumeGomez deleted the env-docs branch December 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants