Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Waker::noop API in tests #118948

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Use the Waker::noop API in tests #118948

merged 1 commit into from
Dec 15, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 14, 2023

Avoids the need to duplicate this code over and over again

r? eholk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2023
@eholk
Copy link
Contributor

eholk commented Dec 14, 2023

That's so much nicer!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 14, 2023

📌 Commit 3c17514 has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
…kingjubilee

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118908 (Add all known `target_feature` configs to check-cfg)
 - rust-lang#118933 (Cleanup errors handlers even more)
 - rust-lang#118943 (update `measureme` to 10.1.2 to deduplicate `parking_lot`)
 - rust-lang#118948 (Use the `Waker::noop` API in tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9648c48 into rust-lang:master Dec 15, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
Rollup merge of rust-lang#118948 - compiler-errors:noop, r=eholk

Use the `Waker::noop` API in tests

Avoids the need to duplicate this code over and over again

r? eholk
@rustbot rustbot added this to the 1.76.0 milestone Dec 15, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2023
…rors

coverage: Use `Waker::noop` in async tests

Inspired by rust-lang#118948.

---

`@rustbot` label +A-code-coverage
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
Rollup merge of rust-lang#118969 - Zalathar:waker-noop, r=compiler-errors

coverage: Use `Waker::noop` in async tests

Inspired by rust-lang#118948.

---

`@rustbot` label +A-code-coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants