Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_passes: Enforce rustc::potential_query_instability lint #118870

Merged
merged 1 commit into from
Dec 13, 2023
Merged

rustc_passes: Enforce rustc::potential_query_instability lint #118870

merged 1 commit into from
Dec 13, 2023

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Dec 12, 2023

Stop allowing rustc::potential_query_instability in all of rustc_passes and instead allow it on a case-by-case basis if it is safe. In this case, all instances of the lint are safe to allow.

Part of #84447 which is E-help-wanted.

@Enselic
rustc_passes: Enforce rustc::potential_query_instability lint
e9b16cc 
Stop allowing `rustc::potential_query_instability` in all of
`rustc_passes` and instead allow it on a case-by-case basis if it is
safe. In this case, all instances of the lint are safe to allow.
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 12, 2023
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2023

📌 Commit e9b16cc has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned b-naber Dec 12, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2023
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 12, 2023
@GuillaumeGomez
Rollup merge of rust-lang#118870 - Enselic:rustc_passes-query-stabili…
5ae76ae 
…ty, r=compiler-errors

rustc_passes: Enforce `rustc::potential_query_instability` lint

Stop allowing `rustc::potential_query_instability` in all of `rustc_passes` and instead allow it on a case-by-case basis if it is safe. In this case, all instances of the lint are safe to allow.

Part of rust-lang#84447 which is E-help-wanted.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 12, 2023
Closed
cjgillot
cjgillot reviewed Dec 12, 2023
View reviewed changes
compiler/rustc_passes/src/stability.rs
@@ -1048,6 +1048,9 @@ pub fn check_unused_or_stable_features(tcx: TyCtxt<'_>) {
tcx.sess.emit_err(errors::UnknownFeature { span, feature: *feature });
}

// We only use the hash map contents to emit errors, and the order of
// emitted errors do not affect query stability.
#[allow(rustc::potential_query_instability)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having different outputs for different platforms is a bug, even for diagnostics.

@bors
Copy link
Contributor

bors commented Dec 13, 2023

⌛ Testing commit e9b16cc with merge c3def26...

@bors
Copy link
Contributor

bors commented Dec 13, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing c3def26 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 13, 2023
@bors bors merged commit c3def26 into rust-lang:master Dec 13, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 13, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c3def26): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Warning ⚠: The following benchmark(s) failed to build:

  • libc-0.2.124
  • cranelift-codegen-0.82.1
  • image-0.24.1

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 13.5% [0.5%, 44.5%] 8
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 13.5% [0.5%, 44.5%] 8

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [1.6%, 6.3%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [1.6%, 6.3%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 13.4% [0.7%, 39.3%] 7
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 13.4% [0.7%, 39.3%] 7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.712s -> 672.982s (0.19%)
Artifact size: 312.46 MiB -> 312.42 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Dec 13, 2023
@lqd
Copy link
Member

lqd commented Dec 13, 2023

This is the periodical "slow s3 uploads on the collector", nothing to worry about: the timeouts are not due to this PR. There are no functional changes here in the first place.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Enselic @rustbot @compiler-errors @bors @rust-timer @lqd @cjgillot @b-naber