refactor writeback: emit normalization errors with new solver #118751

lcnr · 2023-12-08T16:31:00Z

implements #118725 (comment)

r? @compiler-errors @BoxyUwU whoever comes first n stuff

rustbot · 2023-12-08T16:31:10Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

lcnr · 2023-12-08T16:31:18Z

@bors try @rust-timer queue

bors · 2023-12-08T16:32:30Z

⌛ Trying commit 84a6e68 with merge ed0e78e...

refactor writeback: emit normalization errors with new solver implements rust-lang#118725 (comment) r? `@compiler-errors` `@BoxyUwU` whoever comes first n stuff

bors · 2023-12-08T17:59:10Z

☀️ Try build successful - checks-actions
Build commit: ed0e78e (ed0e78e6d3430212e3a2ed7956d69aa74a77559f)

rust-timer · 2023-12-08T19:20:51Z

Finished benchmarking commit (ed0e78e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	2.1%	[1.0%, 4.9%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.635s -> 675.44s (-0.03%)
Artifact size: 314.02 MiB -> 314.03 MiB (0.00%)

compiler/rustc_hir_typeck/src/writeback.rs

compiler-errors · 2023-12-08T21:49:48Z

compiler/rustc_hir_typeck/src/lib.rs

@@ -283,8 +283,6 @@ fn typeck_with_fallback<'tcx>(

    fcx.check_asms();

-    fcx.infcx.skip_region_resolution();


Hm... seems a bit sketch. Idk if I have any better ideas other than this though...

I think this is fine.

We only did this to enable the use of fully_resolve in writeback to also resolve regions. But given that we resolve all regions to 'erased anyways, this is pretty pointless and resolve_vars_if_possible is good enough.

compiler-errors · 2023-12-11T18:04:45Z

compiler/rustc_hir_typeck/src/writeback.rs

-// promises. It is expected that we will have already reported any
-// errors that may be encountered, so if the promises store an error,
-// a dummy result is returned.
+    fn fold_predicate(&mut self, predicate: ty::Predicate<'tcx>) -> ty::Predicate<'tcx> {


When do we resolve predicates during writeback?

https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/struct.TypeckResults.html#structfield.coroutine_interior_predicates

compiler-errors · 2023-12-12T15:41:22Z

@bors r+

bors · 2023-12-12T15:41:25Z

📌 Commit 0bea818 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-12-12T16:15:00Z

⌛ Testing commit 0bea818 with merge 835ed00...

bors · 2023-12-12T18:19:29Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 835ed00 to master...

rust-timer · 2023-12-12T19:41:22Z

Finished benchmarking commit (835ed00): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.2%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.9%, 1.4%]	2
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.8%, -2.6%]	2
All ❌✅ (primary)	1.1%	[0.9%, 1.4%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.136s -> 672.534s (-0.09%)
Artifact size: 312.33 MiB -> 312.27 MiB (-0.02%)

rustbot assigned compiler-errors Dec 8, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Dec 8, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2023

compiler-errors reviewed Dec 11, 2023

View reviewed changes

lcnr added 2 commits December 12, 2023 12:20

refactor writeback: emit normalization errors with new solver

6ffe36b

review + rename fn

0bea818

rust-cloud-vms bot force-pushed the writeback-change branch from 84a6e68 to 0bea818 Compare December 12, 2023 12:29

compiler-errors approved these changes Dec 12, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2023

bors merged commit 835ed00 into rust-lang:master Dec 12, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Dec 12, 2023

matthiaskrgr mentioned this pull request Dec 13, 2023

ICE with nested impl and closure capture #117802

Closed

matthiaskrgr mentioned this pull request Dec 13, 2023

ICE in mir building with captured value of unresolved type, None in compiler/rustc_mir_build/src/build/expr/as_place.rs #110453

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor writeback: emit normalization errors with new solver #118751

refactor writeback: emit normalization errors with new solver #118751

lcnr commented Dec 8, 2023

rustbot commented Dec 8, 2023

lcnr commented Dec 8, 2023

This comment has been minimized.

bors commented Dec 8, 2023

bors commented Dec 8, 2023

This comment has been minimized.

rust-timer commented Dec 8, 2023

compiler-errors Dec 8, 2023

lcnr Dec 12, 2023

compiler-errors Dec 11, 2023

lcnr Dec 12, 2023

compiler-errors Dec 12, 2023

compiler-errors commented Dec 12, 2023

bors commented Dec 12, 2023

bors commented Dec 12, 2023

bors commented Dec 12, 2023

rust-timer commented Dec 12, 2023

		@@ -283,8 +283,6 @@ fn typeck_with_fallback<'tcx>(

		fcx.check_asms();

		fcx.infcx.skip_region_resolution();

refactor writeback: emit normalization errors with new solver #118751

refactor writeback: emit normalization errors with new solver #118751

Conversation

lcnr commented Dec 8, 2023

rustbot commented Dec 8, 2023

lcnr commented Dec 8, 2023

This comment has been minimized.

bors commented Dec 8, 2023

bors commented Dec 8, 2023

This comment has been minimized.

rust-timer commented Dec 8, 2023

Overall result: ✅ improvements - no action needed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

compiler-errors commented Dec 12, 2023

bors commented Dec 12, 2023

bors commented Dec 12, 2023

bors commented Dec 12, 2023

rust-timer commented Dec 12, 2023

Overall result: ✅ improvements - no action needed