Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] 1.74.1 release #118607

Merged
merged 10 commits into from
Dec 4, 2023
Merged

[stable] 1.74.1 release #118607

merged 10 commits into from
Dec 4, 2023

Conversation

Mark-Simulacrum
Copy link
Member

This includes backports of:

As well as infrastructure fix:

r? @Mark-Simulacrum

wesleywiser and others added 10 commits December 4, 2023 09:51
@wesleywiser @Mark-Simulacrum
Dispose llvm::TargetMachines prior to llvm::Context being disposed
2303087 
If the TargetMachine is disposed after the Context is disposed, it can
lead to use after frees in some cases.

I've observed this happening occasionally on code compiled for
aarch64-pc-windows-msvc using `-Zstack-protector=strong` but other users
have reported AVs from host aarch64-pc-windows-msvc compilers as well.
@wesleywiser @cuviper @Mark-Simulacrum
Update compiler/rustc_codegen_llvm/src/lib.rs
f0444a5 
Co-authored-by: Josh Stone <[email protected]>
@lcnr @Mark-Simulacrum
only free lifetimes may get erased
97dcd63
@ouz-a @Mark-Simulacrum
subtyping_projections
fa7a318
@ouz-a @Mark-Simulacrum
Add docs, remove code, change subtyper code
caab4b7
@ouz-a @Mark-Simulacrum
change is_subtype to relate_types
41b0ddd
@ouz-a @Mark-Simulacrum
have better explanation for relate_types
63976da
@ouz-a @Mark-Simulacrum
move subtyper change reveal_all
8c7bc2f
@Mark-Simulacrum
Add release notes for 1.74.1
66033ec
@lnicola @Mark-Simulacrum
Don't ask for a specific branch in cargotest
de148ec
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Dec 4, 2023
@apiraino apiraino mentioned this pull request Dec 4, 2023
Closed
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=10

@bors
Copy link
Contributor

bors commented Dec 4, 2023

📌 Commit de148ec has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023
@bors
Copy link
Contributor

bors commented Dec 4, 2023

⌛ Testing commit de148ec with merge a28077b...

@bors
Copy link
Contributor

bors commented Dec 4, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing a28077b to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2023
@bors bors merged commit a28077b into rust-lang:stable Dec 4, 2023
12 checks passed
@rustbot rustbot added this to the 1.74.1 milestone Dec 4, 2023
@taiki-e taiki-e mentioned this pull request Dec 7, 2023
Closed
@sksat sksat mentioned this pull request Dec 18, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#119068 - sksat:copy-1.74.1-release-note-to-…
e8046d3 
…master, r=Mark-Simulacrum

Copy 1.74.1 release notes to master

- rust-lang#119065
- this cherry-pick 1.74.1 release note from rust-lang#118607(66033ec)

Fixes rust-lang#119065.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023
@rust-timer
Unrolled build for rust-lang#119068
b7c65a2 
Rollup merge of rust-lang#119068 - sksat:copy-1.74.1-release-note-to-master, r=Mark-Simulacrum

Copy 1.74.1 release notes to master

- rust-lang#119065
- this cherry-pick 1.74.1 release note from rust-lang#118607(66033ec)

Fixes rust-lang#119065.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.1
Development

Successfully merging this pull request may close these issues.
7 participants
@Mark-Simulacrum @rustbot @bors @wesleywiser @lcnr @ouz-a @lnicola