Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_hir cleanups #118121

Merged
merged 7 commits into from
Nov 21, 2023
Merged

rustc_hir cleanups #118121

merged 7 commits into from
Nov 21, 2023

Conversation

nnethercote
Copy link
Contributor

Just some improvements I found while looking at this code.

r? @WaffleLapkin

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2023

Could not assign reviewer from: WaffleLapkin.
User(s) WaffleLapkin are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2023
compiler-errors
compiler-errors approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when ci is green

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 21, 2023

📌 Commit 72653c1 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2023
@Noratrieb Noratrieb mentioned this pull request Nov 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@bors
Auto merge of rust-lang#118126 - Nilstrieb:rollup-5ogh896, r=Nilstrieb
c5af061 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#117790 (CFI: Add missing use core::ffi::c_int)
 - rust-lang#118059 (Explicitly unset $CARGO for compiletest)
 - rust-lang#118081 (`rustc_ty_utils` cleanups)
 - rust-lang#118094 (feat: specialize `SpecFromElem` for `()`)
 - rust-lang#118097 (Update books)
 - rust-lang#118115 (Fix occurrences of old fn names in comment and tracing)
 - rust-lang#118121 (`rustc_hir` cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f13f980 into rust-lang:master Nov 21, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@rust-timer
Unrolled build for rust-lang#118121
0927ca8 
Rollup merge of rust-lang#118121 - nnethercote:rustc_hir, r=compiler-errors

`rustc_hir` cleanups

Just some improvements I found while looking at this code.

r? `@WaffleLapkin`
@rustbot rustbot added this to the 1.76.0 milestone Nov 21, 2023
@nnethercote nnethercote deleted the rustc_hir branch November 21, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @rustbot @compiler-errors @bors