-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary -fembed-bitcode usage now that it's deprecated #118014
Remove unnecessary -fembed-bitcode usage now that it's deprecated #118014
Conversation
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
This depends on that linked PR being in a cc-rs release, which it was but that version was yanked https://github.com/rust-lang/cc-rs/releases/tag/1.0.84, we need to wait to merge this until that's ready, but I wanted to get CI running now |
☔ The latest upstream changes (presumably #122504) made this pull request unmergeable. Please resolve the merge conflicts. |
This is a partial revert of 6d819a4 because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore
f490968
to
096a08e
Compare
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
there have been a few cc-rs updates since, so i think we should be ready here |
@bors r+ rollup=never |
☀️ Test successful - checks-actions |
thanks! |
Finished benchmarking commit (474bee7): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -1.4%, secondary -1.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 6.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.213s -> 670.162s (-0.16%) |
This is a partial revert of 6d819a4 because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore