Allow codegen backends to opt-out of parallel codegen #116791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
I did changes against quite an old version and now it does not work, should have checked... |
WaffleLapkin
added
S-waiting-on-author
oli-obk
reviewed
Oct 16, 2023
| @@ -383,6 +383,12 @@ impl<B: WriteBackendMethods> CodegenContext<B> { | |||
| } | |||
| } | |||
|
|
|||
| impl<B: CodegenBackend + WriteBackendMethods> CodegenContext<B> { | |||
| pub fn parallel(&self) -> bool { | |||
| self.backend.supports_parallel() && !self.opts.unstable_opts.no_parallel_llvm | |||
There was a problem hiding this comment.
the name about llvm seems suboptimal (or should only be checked in codegen_llvm)
There was a problem hiding this comment.
maybe no_parallel_backend?
And backend is one of parameters of start_executing_work so we can call supports_parallel inside it
|
(for reference, the problem with the build is that |
|
@WaffleLapkin any updates on this? |
|
@Dylan-DPC I still need to figure a way to fix conflicts |
rust-cloud-vms
bot
force-pushed
the
unparallel-backends
branch
from
23b0c96
to
f368922
Compare
|
Ok, this was easier than I thought. Dunno why I procrastinated fixing conflicts for so long 😅 |
rustbot
removed
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
|
r? @oli-obk |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 11, 2024
…r=oli-obk Allow codegen backends to opt-out of parallel codegen This makes it a bit easier to write cursed codegen backends.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2024
…kingjubilee Rollup of 15 pull requests Successful merges: - rust-lang#116791 (Allow codegen backends to opt-out of parallel codegen) - rust-lang#116793 (Allow targets to override default codegen backend) - rust-lang#117458 (LLVM Bitcode Linker: A self contained linker for nvptx and other targets) - rust-lang#119385 (Fix type resolution of associated const equality bounds (take 2)) - rust-lang#121438 (std support for wasm32 panic=unwind) - rust-lang#121893 (Add tests (and a bit of cleanup) for interior mut handling in promotion and const-checking) - rust-lang#122080 (Clarity improvements to `DropTree`) - rust-lang#122152 (Improve diagnostics for parenthesized type arguments) - rust-lang#122166 (Remove the unused `field_remapping` field from `TypeLowering`) - rust-lang#122249 (interpret: do not call machine read hooks during validation) - rust-lang#122299 (Store backtrace for `must_produce_diag`) - rust-lang#122318 (Revision-related tweaks for next-solver tests) - rust-lang#122320 (Use ptradd for vtable indexing) - rust-lang#122328 (unix_sigpipe: Replace `inherit` with `sig_dfl` in syntax tests) - rust-lang#122330 (bootstrap readme: fix, improve, update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2024
Rollup merge of rust-lang#116791 - WaffleLapkin:unparallel-backends, r=oli-obk Allow codegen backends to opt-out of parallel codegen This makes it a bit easier to write cursed codegen backends.
TimNN
added a commit
to TimNN/rustc-dev-guide
that referenced
this pull request
Apr 3, 2024
This was renamed by rust-lang/rust#116791.
tshepang
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 5, 2024
This was renamed by rust-lang/rust#116791.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a bit easier to write cursed codegen backends.