Some codegen cleanups around SIMD checks #116267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
wesleywiser
changed the title
|
r? compiler |
bjorn3
reviewed
Oct 30, 2023
This comment was marked as resolved.
This comment was marked as resolved.
…nvocation arguments into the macro
…imd, as these always go together.
oli-obk
force-pushed
the
simd_cleanups
branch
from
c694a62
to
f8372df
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116267 (Some codegen cleanups around SIMD checks) - rust-lang#116712 (When encountering unclosed delimiters during lexing, check for diff markers) - rust-lang#117416 (Also consider TAIT to be uncomputable if the MIR body is tainted) - rust-lang#117421 (coverage: Replace impossible `coverage::Error` with assertions) - rust-lang#117438 (Do not ICE on constant evaluation failure in GVN.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2023
Rollup merge of rust-lang#116267 - oli-obk:simd_cleanups, r=petrochenkov Some codegen cleanups around SIMD checks See rust-lang#115933 (comment) for the reason. This PR essentially just deduplicates code by moving it into a macro
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Nov 1, 2023
78: Automated pull from upstream `master` r=tshepang a=github-actions[bot] This PR pulls the following changes from the upstream repository: * rust-lang/rust#113970 * rust-lang/rust#117459 * rust-lang/rust#117451 * rust-lang/rust#117439 * rust-lang/rust#117417 * rust-lang/rust#117388 * rust-lang/rust#113241 * rust-lang/rust#117462 * rust-lang/rust#117450 * rust-lang/rust#117407 * rust-lang/rust#117444 * rust-lang/rust#117438 * rust-lang/rust#117421 * rust-lang/rust#117416 * rust-lang/rust#116712 * rust-lang/rust#116267 * rust-lang/rust#117377 * rust-lang/rust#117419 Co-authored-by: Alexis (Poliorcetics) Bourget <[email protected]> Co-authored-by: Esteban Küber <[email protected]> Co-authored-by: David Tolnay <[email protected]> Co-authored-by: Celina G. Val <[email protected]> Co-authored-by: Michael Goulet <[email protected]> Co-authored-by: bors <[email protected]> Co-authored-by: Camille GILLOT <[email protected]> Co-authored-by: lcnr <[email protected]> Co-authored-by: Zalathar <[email protected]> Co-authored-by: Oli Scherer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #115933 (comment) for the reason.
This PR essentially just deduplicates code by moving it into a macro