Add check_unused_messages in tidy #115863

chenyukang · 2023-09-15T02:32:27Z

From #115728 (comment)
The check is not 100% accurate, I guess it's enough for now.

rustbot · 2023-09-15T02:32:35Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

Mark-Simulacrum

r? @davidtwco perhaps -- want to check on:

Is there some risk with deleting ftl strings, e.g., for translations?
Can we rely on some other tooling to manage unused detection for us? Feels like the heuristic here is a bit rough vs. potentially something built in to the compiler or so.

Mark-Simulacrum · 2023-09-18T00:06:10Z

src/tools/tidy/src/fluent_checks.rs

+        let name = m.get(1).unwrap();
+        // message maybe referenced as {name} in fluent files
+        let name_var = "{".to_string() + name.as_str() + "}";
+        if !sources.iter().any(|file| file.contains(name.as_str())) && !fluent.contains(&name_var) {


This feels like it might get quite slow. It seems like we're scanning ~every Rust file in the same compiler crate for each fluent string. But, maybe OK for now, I don't think we need to block on it at this time.

davidtwco · 2023-09-20T10:00:47Z

I think something like this is worth doing, but this does seem like an expensive check. I've had some ideas for how we can do a bunch of our Fluent infrastructure better and it would solve this, I've pinged @chenyukang on Zulip about this to see if they're interested in working on that.

chenyukang · 2023-09-20T11:10:44Z

Thanks @davidtwco , I will take a look at your thoughts.
I removed the tidy check and kept only the cleanup in this PR.

davidtwco · 2023-10-03T10:03:44Z

@bors r+

bors · 2023-10-03T10:03:47Z

📌 Commit 42a033a has been approved by davidtwco

It is now in the queue for this repository.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#115863 (Add check_unused_messages in tidy) - rust-lang#116210 (Ensure that `~const` trait bounds on associated functions are in const traits or impls) - rust-lang#116358 (Rename both of the `Match` relations) - rust-lang#116371 (Remove unused features from `rustc_llvm`.) - rust-lang#116374 (Print normalized ty) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#115863 - chenyukang:yukang-add-message-tidy-check, r=davidtwco Add check_unused_messages in tidy From rust-lang#115728 (comment) The check is not 100% accurate, I guess it's enough for now.

rustbot assigned Mark-Simulacrum Sep 15, 2023

Mark-Simulacrum reviewed Sep 18, 2023

View reviewed changes

rustbot assigned davidtwco and unassigned Mark-Simulacrum Sep 18, 2023

chenyukang force-pushed the yukang-add-message-tidy-check branch from 25cf1ef to f200999 Compare September 20, 2023 11:08

Cleanup unused messages in ftl files

42a033a

chenyukang force-pushed the yukang-add-message-tidy-check branch from f200999 to 42a033a Compare September 20, 2023 11:09

davidtwco approved these changes Oct 3, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023

matthiaskrgr mentioned this pull request Oct 3, 2023

Rollup of 5 pull requests #116376

Merged

bors merged commit 144862e into rust-lang:master Oct 3, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 3, 2023

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add check_unused_messages in tidy #115863

Add check_unused_messages in tidy #115863

chenyukang commented Sep 15, 2023 •

edited

Loading

rustbot commented Sep 15, 2023

Mark-Simulacrum left a comment

Mark-Simulacrum Sep 18, 2023

davidtwco commented Sep 20, 2023

chenyukang commented Sep 20, 2023

davidtwco commented Oct 3, 2023

bors commented Oct 3, 2023

Add check_unused_messages in tidy #115863

Add check_unused_messages in tidy #115863

Conversation

chenyukang commented Sep 15, 2023 • edited Loading

rustbot commented Sep 15, 2023

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum Sep 18, 2023

Choose a reason for hiding this comment

davidtwco commented Sep 20, 2023

chenyukang commented Sep 20, 2023

davidtwco commented Oct 3, 2023

bors commented Oct 3, 2023

chenyukang commented Sep 15, 2023 •

edited

Loading