Stabilize --json unused-externs(-silent)

[jsgf]

Implement rust-lang/compiler-team#674 (pending its approval)

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[cjgillot]

I see that the proposal has been seconded, but I also saw disagreement by @est31 in zulip. What is the current status?

[jsgf]

@cjgillot I think "disagreement" is overstating it - I think a fair summary of @est31's concern is that since Cargo doesn't currently use there's options there's a possibility they'd need to be changed in some way when it does. I think that's unlikely in practice, esp since 1) we have practical experience that this mechanism works well in general and 2) there is a prototype for Cargo which explores the design space.

[bors]

☔ The latest upstream changes (presumably #119063) made this pull request unmergeable. Please resolve the merge conflicts.

[apiraino]

Adding a note that this PR is waiting the FCP to complete

@rustbot label S-waiting-on-fcp -S-waiting-on-author +S-waiting-on-team

[oli-obk]

The MCP has been accepted

[JohnCSimon]

ping from triage - can you post your status on this PR? This PR has not received an update in a few months.
@jsgf

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

Or if you're not going to continue, please close it. Thank you!

[jsgf]

Oh yeah I need to push it over the line.

[jsgf]

@JohnCSimon OK I just pushed a rebase onto current master.

[jsgf]

@rustbot ready

[oli-obk]

r? @oli-obk

@bors r+

[bors]

📌 Commit 8880b70 has been approved by oli-obk

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8880b70 with merge d493fd1...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d493fd1 to master...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing d493fd1 to master...

[rust-timer]

Finished benchmarking commit (d493fd1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.8%	[-9.5%, -2.1%]	3
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-4.8%	[-9.5%, -2.1%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 679.002s -> 678.734s (-0.04%)
Artifact size: 316.01 MiB -> 316.01 MiB (-0.00%)