Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bootstrap rustc version check #115103

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Disable bootstrap rustc version check #115103

merged 1 commit into from
Aug 23, 2023

Conversation

djkoloski
Copy link
Contributor

Mitigates #115065

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2023

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 22, 2023
@compiler-errors
Copy link
Member

For ther record: was added in #112231, cc @chenyukang. And it was suggested removing it here: #115065 (comment)

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 22, 2023

📌 Commit 6aef5b3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 22, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 22, 2023
@matthiaskrgr
Rollup merge of rust-lang#115103 - djkoloski:disable_bootstrap_versio…
1216cc4 
…n_check, r=compiler-errors

Disable bootstrap rustc version check

Mitigates rust-lang#115065
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 23, 2023
@bors
Auto merge of rust-lang#115137 - GuillaumeGomez:rollup-37jqoyg, r=Gui…
8e8231f 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#114696 (Fix a pthread_t handle leak rust-lang#114610)
 - rust-lang#115102 (Improve note for the `invalid_reference_casting` lint)
 - rust-lang#115103 (Disable bootstrap rustc version check)
 - rust-lang#115106 (ArchiveWrapper: handle LLVM API update)
 - rust-lang#115109 (Skip ExpandYamlAnchors when the config is missing)
 - rust-lang#115135 (Rustdoc: Add unstable --no-html-source flag)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b3949c0 into rust-lang:master Aug 23, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 23, 2023
@onur-ozkan onur-ozkan mentioned this pull request Oct 22, 2023
Merged
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 29, 2023
@workingjubilee
Rollup merge of rust-lang#117043 - onur-ozkan:skip-stage0-validation,…
d562fd5 
… r=Mark-Simulacrum

add bootstrap flag `--skip-stage0-validation`

This change introduces the `--skip-stage0-validation` flag, which permits the use of any desired version of the stage0 compiler without verifying its version.

Additionally, stage0 compiler validation check is reverted(rust-lang#115103) to its default enabled state.

Helps to rust-lang#115065

r? Mark-Simulacrum
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 29, 2023
@GuillaumeGomez
Rollup merge of rust-lang#117043 - onur-ozkan:skip-stage0-validation,…
806492a 
… r=Mark-Simulacrum

add bootstrap flag `--skip-stage0-validation`

This change introduces the `--skip-stage0-validation` flag, which permits the use of any desired version of the stage0 compiler without verifying its version.

Additionally, stage0 compiler validation check is reverted(rust-lang#115103) to its default enabled state.

Helps to rust-lang#115065

r? Mark-Simulacrum
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 29, 2023
@GuillaumeGomez
Rollup merge of rust-lang#117043 - onur-ozkan:skip-stage0-validation,…
20debcd 
… r=Mark-Simulacrum

add bootstrap flag `--skip-stage0-validation`

This change introduces the `--skip-stage0-validation` flag, which permits the use of any desired version of the stage0 compiler without verifying its version.

Additionally, stage0 compiler validation check is reverted(rust-lang#115103) to its default enabled state.

Helps to rust-lang#115065

r? Mark-Simulacrum
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2023
@rust-timer
Unrolled build for rust-lang#117043
858c73c 
Rollup merge of rust-lang#117043 - onur-ozkan:skip-stage0-validation, r=Mark-Simulacrum

add bootstrap flag `--skip-stage0-validation`

This change introduces the `--skip-stage0-validation` flag, which permits the use of any desired version of the stage0 compiler without verifying its version.

Additionally, stage0 compiler validation check is reverted(rust-lang#115103) to its default enabled state.

Helps to rust-lang#115065

r? Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertlarsan68 albertlarsan68

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
5 participants
@djkoloski @rustbot @compiler-errors @bors @albertlarsan68