-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Rename typedef to type alias #115078
Conversation
This matches the name used by the Rust Reference [1], which is also what people usually call these items. [1]: https://doc.rust-lang.org/reference/items/type-aliases.html
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
Thanks! r=me once CI pass |
This comment has been minimized.
This comment has been minimized.
Some changes occurred in GUI tests. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good WRT Rustdoc-JSON couple of naming nits to keeps the tools consistant with the lib. Running a find and replace of inner.typedef
to inner.type_alias
should fix most of the rustdoc-json tests.
@bors r=aDotInTheVoid,GuillaumeGomez |
☀️ Test successful - checks-actions |
Finished benchmarking commit (9bd60a6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.475s -> 631.241s (-0.20%) |
Just wanted to say thanks :D The use of a wrong term bothered me a while ago but not enough to create an issue right away. Now I thought I'd finally create one, but when I double-checked the docs it was already fixed 👍 |
This matches the name used by the Rust Reference, which is also what
people usually call these items.
r? @GuillaumeGomez