Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE failed to get layout for ReferencesError #114450

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix ICE failed to get layout for ReferencesError #114450

merged 1 commit into from
Aug 4, 2023

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Aug 4, 2023 •
edited by compiler-errors
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2023

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-114435 branch 2 times, most recently from ad2bda2 to c0eb009 Compare August 4, 2023 14:40
@compiler-errors
Copy link
Member

Did you try // build-fail in the UI test suite?

@chenyukang
Copy link
Member Author

It works!
but the error message comes from the first line, so I added this at the head:

//~ ERROR: the type has an unknown layout

it's expected? 🤔

compiler-errors
compiler-errors approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if ci is happy

@compiler-errors
Copy link
Member

you can also use // error-pattern: ASDJZXCHXZ instead of having to do //~, it'll just search for a specific error message regardless of the line. But this is fine too.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 4, 2023

📌 Commit 3d25b5c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 4, 2023
@bors
Auto merge of rust-lang#114481 - matthiaskrgr:rollup-58pczpl, r=matth…
e4c1446 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#113945 (Fix wrong span for trait selection failure error reporting)
 - rust-lang#114351 ([rustc_span][perf] Remove unnecessary string joins and allocs.)
 - rust-lang#114418 (bump parking_lot to 0.12)
 - rust-lang#114434 (Improve spans for indexing expressions)
 - rust-lang#114450 (Fix ICE failed to get layout for ReferencesError)
 - rust-lang#114461 (Fix unwrap on None)
 - rust-lang#114462 (interpret: add mplace_to_ref helper method)
 - rust-lang#114472 (Reword `confusable_idents` lint)
 - rust-lang#114477 (Account for `Rc` and `Arc` when suggesting to clone)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a0fd747 into rust-lang:master Aug 4, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Aug 4, 2023
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Aug 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#114450 - chenyukang:yukang-fix-114435, r=co…
88a79c6 
…mpiler-errors

Fix ICE failed to get layout for ReferencesError

Fixes rust-lang#114435

r? `@compiler-errors`
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 11, 2023
@bors
Auto merge of rust-lang#114481 - matthiaskrgr:rollup-58pczpl, r=matth…
ec1d61e 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#113945 (Fix wrong span for trait selection failure error reporting)
 - rust-lang#114351 ([rustc_span][perf] Remove unnecessary string joins and allocs.)
 - rust-lang#114418 (bump parking_lot to 0.12)
 - rust-lang#114434 (Improve spans for indexing expressions)
 - rust-lang#114450 (Fix ICE failed to get layout for ReferencesError)
 - rust-lang#114461 (Fix unwrap on None)
 - rust-lang#114462 (interpret: add mplace_to_ref helper method)
 - rust-lang#114472 (Reword `confusable_idents` lint)
 - rust-lang#114477 (Account for `Rc` and `Arc` when suggesting to clone)

r? `@ghost`
`@rustbot` modify labels: rollup
antoyo pushed a commit to antoyo/rust that referenced this pull request Oct 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#114450 - chenyukang:yukang-fix-114435, r=co…
7ebcd4d 
…mpiler-errors

Fix ICE failed to get layout for ReferencesError

Fixes rust-lang#114435

r? `@compiler-errors`
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Oct 23, 2023
@bors
Auto merge of rust-lang#114481 - matthiaskrgr:rollup-58pczpl, r=matth…
00b60cd 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#113945 (Fix wrong span for trait selection failure error reporting)
 - rust-lang#114351 ([rustc_span][perf] Remove unnecessary string joins and allocs.)
 - rust-lang#114418 (bump parking_lot to 0.12)
 - rust-lang#114434 (Improve spans for indexing expressions)
 - rust-lang#114450 (Fix ICE failed to get layout for ReferencesError)
 - rust-lang#114461 (Fix unwrap on None)
 - rust-lang#114462 (interpret: add mplace_to_ref helper method)
 - rust-lang#114472 (Reword `confusable_idents` lint)
 - rust-lang#114477 (Account for `Rc` and `Arc` when suggesting to clone)

r? `@ghost`
`@rustbot` modify labels: rollup
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Jun 22, 2024
@bors
Auto merge of rust-lang#114481 - matthiaskrgr:rollup-58pczpl, r=matth…
327903e 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#113945 (Fix wrong span for trait selection failure error reporting)
 - rust-lang#114351 ([rustc_span][perf] Remove unnecessary string joins and allocs.)
 - rust-lang#114418 (bump parking_lot to 0.12)
 - rust-lang#114434 (Improve spans for indexing expressions)
 - rust-lang#114450 (Fix ICE failed to get layout for ReferencesError)
 - rust-lang#114461 (Fix unwrap on None)
 - rust-lang#114462 (interpret: add mplace_to_ref helper method)
 - rust-lang#114472 (Reword `confusable_idents` lint)
 - rust-lang#114477 (Account for `Rc` and `Arc` when suggesting to clone)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

ICE: failed to get layout for {type error}: ReferencesError(ErrorGuaranteed(()))
5 participants
@chenyukang @rustbot @rust-log-analyzer @compiler-errors @bors