Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spans for indexing expressions #114434

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Commits on Aug 4, 2023

  1. Improve spans for indexing expressions

    Indexing is similar to method calls in having an arbitrary
    left-hand-side and then something on the right, which is the main part
    of the expression. Method calls already have a span for that right part,
    but indexing does not. This means that long method chains that use
    indexing have really bad spans, especially when the indexing panics and
    that span in coverted into a panic location.
    
    This does the same thing as method calls for the AST and HIR, storing an
    extra span which is then put into the `fn_span` field in THIR.
    Noratrieb committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5706be1 View commit details
    Browse the repository at this point in the history