rustc_llvm: Link to libkstat on Solaris/SPARC

[inferiorhumanorgans]

getHostCPUName calls into libkstat but as of
LLVM 16.0.6 libLLVMTargetParser is not explicitly
linked against libkstat causing builds to fail
due to undefined symbols.

See also: llvm/llvm-project#64186

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[apiraino]

Switching to waiting on author to incorporate changes. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

[Dylan-DPC]

@inferiorhumanorgans any updates on this?

[inferiorhumanorgans]

@Dylan-DPC

Short version: Sorry, no. If time is an issue, this would be a decent opportunity for someone else to pick it up and refine the PR.

Long version: The continued enshittification of Github (mostly) and the resource intensive nature of Rust (secondarily) really did a number on my motivation to iterate on these PRs so these PRs moved to the back burner. By the time you replied my daily driver's SSD died and I'm currently in the process of getting a new machine set up.

I know that there's a lot of dancing around how big the build artifacts are with rust programs, but combined with having to configure set up and configure a suite of VMs it's a big pain point and part of why they didn't get backed up.

As for Github, I'll try not to belabor the point, but I've moved what I can to Sourcehut and I wish that Rust would standardize on something more open source and user friendly. Contributing to open source projects is a passion thing, I'm not getting paid to do this. So part of the attraction to rust is that the tooling and DX are that good. Github stands in stark contrast. As it stands I'm typing this on a brand new MacBook Pro with the most recent version of Firefox and watching the text input widget and everything below it bounce up and down as I type.

I would've replied sooner but not even pages of pure static text on Github load anymore on anything without a very recent javascript interpreter.

[cuviper]

OK, I only wanted a comment added -- I'll do that myself when I get a chance.

[cuviper]

@bors r+ rollup

[bors]

📌 Commit 855388e has been approved by cuviper

It is now in the queue for this repository.

[inferiorhumanorgans]

@cuviper Ah, I saw emails for few related PRs, so that was meant as a catchall instead of spamming each issue. With some luck I'll have more time to deal with GH and get Solaris and dfbsd envs setup next year.