Squelch a noisy rustc_expand unittest #113942
Conversation
|
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
I would prefer this approach. I'm fine for this to land as a temporary solution. Would you be willing to do this in this PR or in a followup PR? If not I'd be happy to open an issue for this. I suppose In any case, could you please add a FIXME here and r=me afterwards? Thanks. |
Unfortunately that doesn't work because the panic is a non-string value (FatalErrorMarker I think?). It could maybe do a catch_unwind to assert the correct panic is raised. |
fee1-dead
added
S-waiting-on-author
ehuss
force-pushed
the
squelch-bad_path_expr_1
branch
from
294c119
to
1584e5f
Compare
|
OK, I pushed an update that uses a custom EmitterWriter. I tried to avoid creating too much extra code, and share what was already there. As a side note, I changed the default diagnostic-width from |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…ee1-dead Squelch a noisy rustc_expand unittest The test `rustc_parse::tests::bad_path_expr_1` prints an error message to stderr, circumventing libtest's stderr intercept. This causes noise when running tests, in particular they show up 16 times on the GitHub Actions summary page. The solution here is to not use an error emitter that prints to stderr, and instead check that the correct error is generated.
…ee1-dead Squelch a noisy rustc_expand unittest The test `rustc_parse::tests::bad_path_expr_1` prints an error message to stderr, circumventing libtest's stderr intercept. This causes noise when running tests, in particular they show up 16 times on the GitHub Actions summary page. The solution here is to not use an error emitter that prints to stderr, and instead check that the correct error is generated.
…ee1-dead Squelch a noisy rustc_expand unittest The test `rustc_parse::tests::bad_path_expr_1` prints an error message to stderr, circumventing libtest's stderr intercept. This causes noise when running tests, in particular they show up 16 times on the GitHub Actions summary page. The solution here is to not use an error emitter that prints to stderr, and instead check that the correct error is generated.
|
☔ The latest upstream changes (presumably #114054) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
ehuss
force-pushed
the
squelch-bad_path_expr_1
branch
from
1584e5f
to
9914ae3
Compare
|
Rebased due to conflicts. @bors r=fee1-dead |
bors
added
S-waiting-on-bors
…ee1-dead Squelch a noisy rustc_expand unittest The test `rustc_parse::tests::bad_path_expr_1` prints an error message to stderr, circumventing libtest's stderr intercept. This causes noise when running tests, in particular they show up 16 times on the GitHub Actions summary page. The solution here is to not use an error emitter that prints to stderr, and instead check that the correct error is generated.
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#101994 (rand: freebsd update, using getrandom.) - rust-lang#113930 (Add Param and Bound ty to SMIR) - rust-lang#113942 (Squelch a noisy rustc_expand unittest) - rust-lang#113996 (Define CMAKE_SYSTEM_NAME on a cross build targeting DragonFly.) - rust-lang#114070 (Add `sym::iter_mut` + `sym::as_mut_ptr` for Clippy) - rust-lang#114073 (Remove -Z diagnostic-width) - rust-lang#114090 (compiletest: remove ci-specific remap-path-prefix) r? `@ghost` `@rustbot` modify labels: rollup
The test
rustc_parse::tests::bad_path_expr_1prints an error message to stderr, circumventing libtest's stderr intercept. This causes noise when running tests, in particular they show up 16 times on the GitHub Actions summary page. The solution here is to not use an error emitter that prints to stderr, and instead check that the correct error is generated.