-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Step for ascii::Char #113295
Implement Step for ascii::Char #113295
Conversation
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #113491) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #105571) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@rustbot author |
@rustbot blocked |
☔ The latest upstream changes (presumably #114786) made this pull request unmergeable. Please resolve the merge conflicts. |
944816b
to
ef33054
Compare
@rustbot ready |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f9ba43c): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.838s -> 629.86s (-0.16%) |
This allows iterating over ranges of
ascii::Char
, similarly to ranges ofchar
.Note that
ascii::Char
is still unstable, tracked in #110998.