Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print def_id on EarlyBoundRegion debug #112908

Merged

Conversation

spastorino
Copy link
Member

It's not the first time that I can't make sense out of the default debug print on EarlyBoundRegion. As I was working on #112682 I needed this.

I was doing some git archeology and found that we used to print everything https://github.com/spastorino/rust/blob/dfbc9608ce5c9655a36b63f6cc9694f5e4ad9890/src/librustc/util/ppaux.rs#L425-L430 but we lost the ability in some refactor midway.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2023
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

r=me after blessing

please make sure to bless at least tests/ui and tests/mir-opt

@spastorino spastorino force-pushed the add-def-id-to-early-bound-region-debug branch from d7a35ab to 3ef510c Compare June 21, 2023 22:34
@spastorino
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Jun 22, 2023

📌 Commit 3ef510c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2023
@spastorino
Copy link
Member Author

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112876 (Don't substitute a GAT that has mismatched generics in `OpaqueTypeCollector`)
 - rust-lang#112906 (rustdoc: render the body of associated types before the where-clause)
 - rust-lang#112907 (Update cargo)
 - rust-lang#112908 (Print def_id on EarlyBoundRegion debug)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b13c941 into rust-lang:master Jun 22, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants