rust-installer: migrate to clap 4.2, change to 2021 edition and fix few clippy lints #112884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
the
A-meta
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
A-testsuite
|
rust/src/tools/tidy/src/walk.rs Lines 29 to 30 in fe37f37 Should this be removed too? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
klensy
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I'm not sure about the changes to this file.
There was a problem hiding this comment.
Tidy will warn on that .sh file otherwise. There is separate commit for that tab->space replacement, you can check it with 7a61966?diff=unified&w=1 with whitespace hidden.
There was a problem hiding this comment.
I meant that the change to perceived to indentation should be reverted IMO, or at least discussed with @Mark-Simulacrum
There was a problem hiding this comment.
Whatever is needed for tidy to be happy is excluded of this category, ofc.
There was a problem hiding this comment.
This file contained mixed tab/spaces before, anyway :-)
src/tools/rust-installer/test.sh
Outdated
Changes for clap looks trivial and rust-installer tests passed, so i guess all ok. |
|
The CI failure being ignored is fixed in #112962. |
|
Can we avoid coupling a migration to clap and the rustfmt/tidy changes into the same PR? This PR is fairly large and seems feasible to break it up. @rustbot author |
rustbot
removed
the
S-waiting-on-review
|
@rustbot ready |
rustbot
added
S-waiting-on-review
albertlarsan68
approved these changes
Jun 25, 2023
Just run it out of workspace over crate. |
|
Thanks for the PR! |
bors
added
S-waiting-on-bors
|
@bors rollup=never touches critical infrastructure |
|
⌛ Testing commit fd1439e with merge ab12b389db901669010c0643d18f5486c9caaacd... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
One more of https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/MIPS.20failure.20on.20CI |
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jun 26, 2023
Merged
|
Finished benchmarking commit (06c58cb): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 662.314s -> 662.496s (0.03%) |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jul 5, 2023
rust-installer & rls: remove exclusion from rustfmt & tidy <strike>based on rust-lang#112884</strike> `rust-installer` and `rls` no longer submodules, but not removed from exclude list for rustfmt and tidy, preventing running fmt and lints on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rust-installer to clap 4.2, dropping last user of clap v3; changes to 2021 edition, fixes few clippy warns.