-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #112801
Rollup of 8 pull requests #112801
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fe4aec1 - Browse repository at this point
Copy the full SHA fe4aec1View commit details
Commits on Jun 18, 2023
-
Use BorrowFlag instead of explicit isize
The integer type tracking borrow count has a typedef called `BorrowFlag`. This type should be used instead of explicit `isize`.
Configuration menu - View commit details
-
Copy full SHA for c4c428b - Browse repository at this point
Copy the full SHA c4c428bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09707ee - Browse repository at this point
Copy the full SHA 09707eeView commit details -
[doc] poll_fn: explain how to pin captured state safely
Usage of `Pin::new_unchecked(&mut …)` is dangerous with `poll_fn`, even though the `!Unpin`-infectiousness has made things smoother. Nonetheless, there are easy ways to avoid the need for any `unsafe` altogether, be it through `Box::pin`ning, or the `pin!` macro. Since the latter only works within an `async` context, showing an example artifically introducing one ought to help people navigate this subtlety with safety and confidence.
Configuration menu - View commit details
-
Copy full SHA for 94f7a79 - Browse repository at this point
Copy the full SHA 94f7a79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fa9003 - Browse repository at this point
Copy the full SHA 8fa9003View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50c971a - Browse repository at this point
Copy the full SHA 50c971aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 355a689 - Browse repository at this point
Copy the full SHA 355a689View commit details -
Add translatable diagnostic for various strings in resolve::unresolve…
…d_macro_suggestions
Configuration menu - View commit details
-
Copy full SHA for 4b5a5a4 - Browse repository at this point
Copy the full SHA 4b5a5a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c07b50a - Browse repository at this point
Copy the full SHA c07b50aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 493b18b - Browse repository at this point
Copy the full SHA 493b18bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d43683f - Browse repository at this point
Copy the full SHA d43683fView commit details
Commits on Jun 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 29c74d5 - Browse repository at this point
Copy the full SHA 29c74d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b374b20 - Browse repository at this point
Copy the full SHA b374b20View commit details -
Configuration menu - View commit details
-
Copy full SHA for db61375 - Browse repository at this point
Copy the full SHA db61375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2027e98 - Browse repository at this point
Copy the full SHA 2027e98View commit details -
Rollup merge of rust-lang#109970 - danielhenrymantilla:add-poll-fn-pi…
…n-clarifications, r=thomcc [doc] `poll_fn`: explain how to `pin` captured state safely Usage of `Pin::new_unchecked(&mut …)` is dangerous with `poll_fn`, even though the `!Unpin`-infectiousness has made things smoother. Nonetheless, there are easy ways to avoid the need for any `unsafe` altogether, be it through `Box::pin`ning, or the `pin!` macro. Since the latter only works within an `async` context, showing an example artificially introducing one ought to help people navigate this subtlety with safety and confidence. ## Preview https://user-images.githubusercontent.com/9920355/230092494-da22fdcb-0b8f-4ff4-a2ac-aa7d9ead077a.mov ``@rustbot`` label +A-docs
Configuration menu - View commit details
-
Copy full SHA for 78367a8 - Browse repository at this point
Copy the full SHA 78367a8View commit details -
Rollup merge of rust-lang#112705 - WaffleLapkin:simplify_source_calle…
…e_impl, r=cjgillot Simplify `Span::source_callee` impl Imo the iterator impl is easier to grasp.
Configuration menu - View commit details
-
Copy full SHA for 70ff8c2 - Browse repository at this point
Copy the full SHA 70ff8c2View commit details -
Rollup merge of rust-lang#112757 - Danvil:patch-1, r=Mark-Simulacrum
Use BorrowFlag instead of explicit isize The integer type tracking borrow count has a typedef called `BorrowFlag`. This type should be used instead of explicit `isize`.
Configuration menu - View commit details
-
Copy full SHA for 33beedb - Browse repository at this point
Copy the full SHA 33beedbView commit details -
Rollup merge of rust-lang#112768 - NotStirred:translatable_diag/resol…
…ve1, r=WaffleLapkin Rewrite various resolve/diagnostics errors as translatable diagnostics additional question: For trivial strings is it ever accepted to use `fluent_generated::foo` in a `label` for example? Or is an empty struct `Diagnostic` preferred?
Configuration menu - View commit details
-
Copy full SHA for e6ccb11 - Browse repository at this point
Copy the full SHA e6ccb11View commit details -
Rollup merge of rust-lang#112777 - compiler-errors:normalize-weak-mor…
…e, r=oli-obk Continue folding in query normalizer on weak aliases Fixes rust-lang#112752 Fixes rust-lang#112731 (same root cause, so didn't make a test for it) fixes rust-lang#112776 r? ``@oli-obk``
Configuration menu - View commit details
-
Copy full SHA for c8bc2a9 - Browse repository at this point
Copy the full SHA c8bc2a9View commit details -
Rollup merge of rust-lang#112780 - compiler-errors:tait-is-ambig, r=lcnr
Treat TAIT equation as always ambiguous in coherence Not sure why we weren't treating all TAIT equality as ambiguous -- this behavior combined with `DefineOpaqueTypes::No` leads to coherence overlap failures, since we incorrectly consider impls as not overlapping because the obligation `T: From<Foo>` doesn't hold. Fixes rust-lang#112765
Configuration menu - View commit details
-
Copy full SHA for 9c99aec - Browse repository at this point
Copy the full SHA 9c99aecView commit details -
Rollup merge of rust-lang#112783 - compiler-errors:nlb-fnptr-reject-i…
…ce, r=fee1-dead Don't ICE on bound var in `reject_fn_ptr_impls` We may try to use an impl like `impl<T: FnPtr> PartialEq {}` to satisfy a predicate like `for<T> T: PartialEq` -- don't ICE in that case. Fixes rust-lang#112735
Configuration menu - View commit details
-
Copy full SHA for 249bd4b - Browse repository at this point
Copy the full SHA 249bd4bView commit details -
Rollup merge of rust-lang#112794 - bjorn3:fix_lib_global_alloc, r=oli…
…-obk Fix linker failures when #[global_allocator] is used in a dependency Fixes rust-lang#112715
Configuration menu - View commit details
-
Copy full SHA for 1b7f451 - Browse repository at this point
Copy the full SHA 1b7f451View commit details