Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #112801

Closed
wants to merge 23 commits into from

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    fe4aec1 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. Use BorrowFlag instead of explicit isize

    The integer type tracking borrow count has a typedef called `BorrowFlag`. This type should be used instead of explicit `isize`.
    Danvil authored Jun 18, 2023
    Configuration menu
    Copy the full SHA
    c4c428b View commit details
    Browse the repository at this point in the history
  2. Same for BorrowRef

    Danvil authored Jun 18, 2023
    Configuration menu
    Copy the full SHA
    09707ee View commit details
    Browse the repository at this point in the history
  3. [doc] poll_fn: explain how to pin captured state safely

    Usage of `Pin::new_unchecked(&mut …)` is dangerous with `poll_fn`, even
    though the `!Unpin`-infectiousness has made things smoother.
    Nonetheless, there are easy ways to avoid the need for any `unsafe`
    altogether, be it through `Box::pin`ning, or the `pin!` macro. Since the
    latter only works within an `async` context, showing an example
    artifically introducing one ought to help people navigate this subtlety
    with safety and confidence.
    danielhenrymantilla committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    94f7a79 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8fa9003 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    50c971a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    355a689 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4b5a5a4 View commit details
    Browse the repository at this point in the history
  8. Fix tidy

    NotStirred committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    c07b50a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    493b18b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d43683f View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Configuration menu
    Copy the full SHA
    29c74d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b374b20 View commit details
    Browse the repository at this point in the history
  3. Reformatting

    NotStirred committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    db61375 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2027e98 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#109970 - danielhenrymantilla:add-poll-fn-pi…

    …n-clarifications, r=thomcc
    
    [doc] `poll_fn`: explain how to `pin` captured state safely
    
    Usage of `Pin::new_unchecked(&mut …)` is dangerous with `poll_fn`, even though the `!Unpin`-infectiousness has made things smoother. Nonetheless, there are easy ways to avoid the need for any `unsafe` altogether, be it through `Box::pin`ning, or the `pin!` macro. Since the latter only works within an `async` context, showing an example artificially introducing one ought to help people navigate this subtlety with safety and confidence.
    
    ## Preview
    
    https://user-images.githubusercontent.com/9920355/230092494-da22fdcb-0b8f-4ff4-a2ac-aa7d9ead077a.mov
    
    ``@rustbot`` label +A-docs
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    78367a8 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#112705 - WaffleLapkin:simplify_source_calle…

    …e_impl, r=cjgillot
    
    Simplify `Span::source_callee` impl
    
    Imo the iterator impl is easier to grasp.
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    70ff8c2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#112757 - Danvil:patch-1, r=Mark-Simulacrum

    Use BorrowFlag instead of explicit isize
    
    The integer type tracking borrow count has a typedef called `BorrowFlag`. This type should be used instead of explicit `isize`.
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    33beedb View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#112768 - NotStirred:translatable_diag/resol…

    …ve1, r=WaffleLapkin
    
    Rewrite various resolve/diagnostics errors as translatable diagnostics
    
    additional question:
    
    For trivial strings is it ever accepted to use `fluent_generated::foo` in a `label` for example? Or is an empty struct `Diagnostic` preferred?
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    e6ccb11 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#112777 - compiler-errors:normalize-weak-mor…

    …e, r=oli-obk
    
    Continue folding in query normalizer on weak aliases
    
    Fixes rust-lang#112752
    Fixes rust-lang#112731 (same root cause, so didn't make a test for it)
    fixes rust-lang#112776
    
    r? ``@oli-obk``
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    c8bc2a9 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#112780 - compiler-errors:tait-is-ambig, r=lcnr

    Treat TAIT equation as always ambiguous in coherence
    
    Not sure why we weren't treating all TAIT equality as ambiguous -- this behavior combined with `DefineOpaqueTypes::No` leads to coherence overlap failures, since we incorrectly consider impls as not overlapping because the obligation `T: From<Foo>` doesn't hold.
    
    Fixes rust-lang#112765
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    9c99aec View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#112783 - compiler-errors:nlb-fnptr-reject-i…

    …ce, r=fee1-dead
    
    Don't ICE on bound var in `reject_fn_ptr_impls`
    
    We may try to use an impl like `impl<T: FnPtr> PartialEq {}` to satisfy a predicate like `for<T> T: PartialEq` -- don't ICE in that case.
    
    Fixes rust-lang#112735
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    249bd4b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#112794 - bjorn3:fix_lib_global_alloc, r=oli…

    …-obk
    
    Fix linker failures when #[global_allocator] is used in a dependency
    
    Fixes rust-lang#112715
    matthiaskrgr authored Jun 19, 2023
    Configuration menu
    Copy the full SHA
    1b7f451 View commit details
    Browse the repository at this point in the history