Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some rustc_builtin_macros to SessionDiagnostic #112795

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Migrate some rustc_builtin_macros to SessionDiagnostic #112795

merged 2 commits into from
Jun 30, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jun 19, 2023 •
edited
Loading

Part of #100717.

@rustbot label +A-translation

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Jun 19, 2023
@He1pa He1pa force-pushed the translation_builtin_macros branch from df0725c to 1b73708 Compare June 21, 2023 10:38
@He1pa He1pa changed the title Migrate rustc_builtin_macros to SessionDiagnostic Migrate some rustc_builtin_macros to SessionDiagnostic Jun 21, 2023
@He1pa He1pa marked this pull request as ready for review June 21, 2023 10:41
@He1pa He1pa force-pushed the translation_builtin_macros branch 2 times, most recently from 3e56f34 to 83011ab Compare June 21, 2023 11:09
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@He1pa He1pa force-pushed the translation_builtin_macros branch from 83011ab to ba2f003 Compare June 21, 2023 11:53
@He1pa
Copy link
Contributor Author

He1pa commented Jun 21, 2023 •
edited
Loading

@rustbot r?davidtwco

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2023

Failed to set assignee to [cjgillot]: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2023

Failed to set assignee to [davidtwco]: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@cjgillot
Copy link
Contributor

r? @davidtwco

@rustbot rustbot assigned davidtwco and unassigned cjgillot Jun 22, 2023
@bors

This comment was marked as resolved.

Sign in to view
@He1pa He1pa force-pushed the translation_builtin_macros branch from ba2f003 to 3f8c7de Compare June 24, 2023 16:42
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@He1pa He1pa force-pushed the translation_builtin_macros branch from 3f8c7de to 8af8a95 Compare June 24, 2023 17:32
davidtwco
davidtwco approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after fixing this typo.

compiler/rustc_builtin_macros/src/errors.rs Outdated Show resolved Hide resolved
@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2023
@He1pa
Copy link
Contributor Author

He1pa commented Jun 28, 2023

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2023
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 28, 2023

📌 Commit 453603a has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#112795 - He1pa:translation_builtin_macros, …
fe2cdfb 
…r=davidtwco

Migrate some rustc_builtin_macros to SessionDiagnostic

Part of rust-lang#100717.

`@rustbot` label +A-translation
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 29, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 29, 2023
Merged
@compiler-errors compiler-errors mentioned this pull request Jun 30, 2023
Closed
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 30, 2023
@compiler-errors
Rollup merge of rust-lang#112795 - He1pa:translation_builtin_macros, …
ae30e8c 
…r=davidtwco

Migrate some rustc_builtin_macros to SessionDiagnostic

Part of rust-lang#100717.

```@rustbot``` label +A-translation
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2023
@bors
Auto merge of rust-lang#113162 - matthiaskrgr:rollup-fct3wj7, r=matth…
97279e9 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#111322 (Support for native WASM exceptions)
 - rust-lang#112086 (resolve: Remove artificial import ambiguity errors)
 - rust-lang#112234 (refactor `tool_doc!`)
 - rust-lang#112300 (Convert `run-make/coverage-reports` tests to use a custom compiletest mode)
 - rust-lang#112795 (Migrate some rustc_builtin_macros to SessionDiagnostic)
 - rust-lang#113144 (Make the `Elaboratable` trait take clauses)
 - rust-lang#113161 (Fix type privacy lints error message)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f135815 into rust-lang:master Jun 30, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
6 participants
@He1pa @rustbot @rust-log-analyzer @cjgillot @bors @davidtwco