Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #112624

Merged
merged 12 commits into from
Jun 14, 2023
Merged

Rollup of 6 pull requests #112624

merged 12 commits into from
Jun 14, 2023

Commits on Feb 3, 2023

  1. Specify behavior of HashSet::insert

    `HashSet::insert` does not replace the value with equal value.
    
    Fixes rust-lang#107581.
    stepancheg committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e800d5a View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. Stabilize String::leak

    est31 committed May 28, 2023
    Configuration menu
    Copy the full SHA
    3ab0d90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62ee9e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Configuration menu
    Copy the full SHA
    2b40268 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Configuration menu
    Copy the full SHA
    e3a1a11 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Configuration menu
    Copy the full SHA
    fda3c9f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Rollup merge of rust-lang#98202 - aticu:impl_tryfrom_osstr_for_str, r…

    …=Amanieu
    
    Implement `TryFrom<&OsStr>` for `&str`
    
    Recently when trying to work with `&OsStr` I was surprised to find this `impl` missing.
    
    Since the `to_str` method already existed the actual implementation is fairly non-controversial, except for maybe the choice of the error type. I chose an opaque error here instead of something like `std::str::Utf8Error`, since that would already make a number of assumption about the underlying implementation of `OsStr`.
    
    As this is a trait implementation, it is insta-stable, if I'm not mistaken?
    Either way this will need an FCP.
    I chose "1.64.0" as the version, since this is unlikely to land before the beta cut-off.
    
    `@rustbot` modify labels: +T-libs-api
    
    API Change Proposal: rust-lang#99031 (accepted)
    matthiaskrgr authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    4efdb5c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#107619 - stepancheg:hash-set-insert, r=Amanieu

    Specify behavior of HashSet::insert
    
    `HashSet::insert` does not replace the value with equal value.
    
    Fixes rust-lang#107581.
    matthiaskrgr authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d54bb50 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#109814 - est31:stabilize_string_leak, r=Ama…

    …nieu
    
    Stabilize String::leak
    
    Stabilizes the following API:
    
    ```Rust
    impl String {
        pub fn leak(self) -> &'static mut str;
    }
    ```
    
    closes rust-lang#102929
    
    blocked by having an FCP for stabilization.
    matthiaskrgr authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    b8f71ea View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#111974 - Sp00ph:update_guarantees, r=Amanieu

    Update runtime guarantee for `select_nth_unstable`
    
    rust-lang#106933 changed the runtime guarantee for `select_nth_unstable` from O(n) to O(n log n), since the old guarantee wasn't actually met by the implementation at the time. Now with rust-lang#107522, `select_nth_unstable` should be truly linear in runtime, so we can revert its runtime guarantee to O(n). Since rust-lang#106933 was considered a bug fix, this will probably need an FCP because it counts as a new API guarantee.
    
    r? `@Amanieu`
    matthiaskrgr authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c451f7b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#112109 - Alexendoo:unsupported-split-debugi…

    …nfo, r=b-naber
    
    Don't print unsupported split-debuginfo modes with `-Zunstable-options`
    
    Currently unsupported `split-debuginfo` options are enabled by `-Zunstable-options`, for projects that have `-Zunstable-options` for other reasons this can be [an unexpected interaction](rust-lang/rust-clippy#10516 (comment))
    
    This PR makes it so that `--print split-debuginfo -Zunstable-options` doesn't print unsupported modes, so that a cargo config of e.g.
    
    ```toml
    [profile.dev]
    split-debuginfo = "unpacked"
    ```
    
    Would not cause an unsupported mode to be enabled on `x86_64-pc-windows-msvc`
    matthiaskrgr authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    38ed4e5 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#112506 - compiler-errors:const-infer-ice, r…

    …=b-naber
    
    Properly check associated consts for infer placeholders
    
    We only reported an error if it was in a "suggestable" position (according to `is_suggestable_infer_ty`) -- this isn't correct for infer tys that can show up in other places in the constant's type, like behind a dyn trait.
    
    fixes rust-lang#112491
    matthiaskrgr authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c1b4d07 View commit details
    Browse the repository at this point in the history