opaque type cleanup #112466
opaque type cleanup #112466
Conversation
be more explicit in where we only add new hidden types and where we also have to deal with item bounds.
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
| // is responsible for proving these obligations. | ||
| let _ = obligations; | ||
| for &(key, ty) in opaque_types { | ||
| self.insert_hidden_type(key, param_env, ty)?; |
There was a problem hiding this comment.
this was previously broken. register_hidden_type returns both obligations from checking the item bounds and from equating the added hidden type with the previous one. Can't be bothered to write a test for that though 😅 especially cause wf of opaque types is checked separately anyways ^^
|
@bors r+ |
bors
added
S-waiting-on-bors
…er-errors opaque type cleanup the commits are pretty self-contained. r? `@compiler-errors` cc `@oli-obk`
…er-errors opaque type cleanup the commits are pretty self-contained. r? ``@compiler-errors`` cc ``@oli-obk``
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (34d64ab): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 648.85s -> 647.255s (-0.25%) |
| let opaque_ty_hir = tcx.hir().expect_item(opaque_type_key.def_id); | ||
| match opaque_ty_hir.expect_opaque_ty().origin { |
There was a problem hiding this comment.
We also have the is_type_alias_impl_trait query
the commits are pretty self-contained.
r? @compiler-errors cc @oli-obk