Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #111867

Merged
merged 17 commits into from
May 23, 2023
Merged

update Miri #111867

merged 17 commits into from
May 23, 2023

Conversation

RalfJung
Copy link
Member

No description provided.

RalfJung and others added 17 commits May 13, 2023 19:02
@RalfJung
cargo-miri: fix forwarding arguments to cargo
fe63dc3
@bors
Auto merge of rust-lang#2896 - RalfJung:cargo-miri-args, r=RalfJung
68941d4 
cargo-miri: fix forwarding arguments to cargo

Fixes rust-lang/miri#2829
@RalfJung
support array return types in simd_bitmask
e75d91d
@bors
Auto merge of rust-lang#2895 - RalfJung:simd_bitmask, r=RalfJung
405fe11 
support array return types in simd_bitmask

Fixes rust-lang/miri#2734

As usual I am stomped by the simd_bitmask behavior wrt endianess. I confirmed that for little endian, Miri matches what rustc currently does, but I can't test rustc on big endian. `@workingjubilee` `@calebzulawski` could you have a look whether those new tests make sense?
@RalfJung
Preparing for merge from rustc
0331912
@RalfJung
Merge from rustc
ed0573f
@bors
Auto merge of rust-lang#2897 - RalfJung:rustup, r=RalfJung
2e17ac8 
Rustup
@RalfJung
Preparing for merge from rustc
d4ce8ed
@RalfJung
Merge from rustc
4014b17
@bors
Auto merge of rust-lang#2898 - RalfJung:rustup, r=RalfJung
a4fb414 
Rustup
@saethlin
Use a signal handler to observe ctrl+c and cleanly drop the measureme…
56eb087 
… profiler
@bors
Auto merge of rust-lang#2899 - saethlin:measureme-cleanup, r=RalfJung
aee196f 
Try to ensure measureme output is valid when the interpreter is interrupted

Dropping our `measureme::Profiler` will have the profiler flush its output buffer and write out its string table. If the profiler's `Drop` impl does not run, the output file is not usable.

This approach has zero runtime overhead.
@oli-obk
Preparing for merge from rustc
a43c5d8
@oli-obk
Merge from rustc
32e52e8
@oli-obk
Update to latest clippy
90459e8
@bors
Auto merge of rust-lang#2900 - oli-obk:rustup, r=oli-obk
4b05125 
Rustup
@RalfJung
update lockfile
13e4766
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented May 23, 2023

📌 Commit 13e4766 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2023
@bors
Copy link
Contributor

bors commented May 23, 2023

⌛ Testing commit 13e4766 with merge 5ea3f0a...

@bors
Copy link
Contributor

bors commented May 23, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 5ea3f0a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2023
@bors bors merged commit 5ea3f0a into rust-lang:master May 23, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 23, 2023
@bors bors mentioned this pull request May 24, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5ea3f0a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.707s -> 646.95s (-0.12%)

@RalfJung RalfJung deleted the miri branch June 3, 2023 14:50
@Skepfyr Skepfyr mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
7 participants
@RalfJung @rustbot @bors @rust-timer @Mark-Simulacrum @saethlin @oli-obk