Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync portable-simd to 2023 May 10 #111475

Merged
merged 92 commits into from
May 12, 2023
Merged

Sync portable-simd to 2023 May 10 #111475

merged 92 commits into from
May 12, 2023

Conversation

workingjubilee
Copy link
Member

Take 2.

r? @ghost

thomcc and others added 30 commits July 21, 2022 14:53
@thomcc
rust-lang/portable-simd#289: Strengthen warnings about relying on Mas…
b5f9d43 
…k layout

This makes it more clear that you can't rely on the layout of these,
which seems worth doing given that the names vaguely suggest that you can
(and the docs only clarify that you can't on Mask but not the maskNxM aliases).
@RalfJung
make some Miri backtraces more pretty
ddede9f
@calebzulawski
Fix interleave/deinterleave for vectors with only one lane
3183afb
@calebzulawski
Merge pull request rust-lang#295 from RalfJung/miri-backtraces
691c8b2 
make some Miri backtraces more pretty
@programmerjake
add all_lane_counts feature to enable non-power-of-2 lane counts <= 64
8742a86
@calebzulawski
Simplify interleave/deinterleave and fix for odd-length vectors.
6bf5128
@calebzulawski
Hide rustc unstable feature from docs
c739af3
@calebzulawski
Remove special case for length-1 vectors
d030301
@calebzulawski
Simplify expression
5f70664
@calebzulawski
Merge pull request rust-lang#299 from rust-lang/interleave-one
7145dc5 
Fix interleave/deinterleave for vectors with only one lane
@programmerjake
Merge pull request rust-lang#300 from programmerjake/all_lane_counts
d5cd4a8 
add all_lane_counts feature to enable non-power-of-2 lane counts <= 64
@miguelraz @workingjubilee
add feature flag
2c5ebfb 
couldn't run the `hellosimd` without it 🤷🏾
@calebzulawski
Mark more mask functions inline
4491309
@calebzulawski
Update readme
ee9a23f
@calebzulawski @programmerjake
Update README.md
f236f57 
Co-authored-by: Jacob Lifshay <[email protected]>
@calebzulawski
Merge pull request rust-lang#309 from rust-lang/mask-inline
2f38f70 
Mark more mask functions inline
@calebzulawski
Merge pull request rust-lang#310 from rust-lang/readme
aad8f0a 
Update readme
@calebzulawski
Specify aliases in one place, and make it more uniform which are defined
61a6f18
@calebzulawski
Improve variable names
402b50a
@calebzulawski
Merge pull request rust-lang#311 from rust-lang/alias
7c80b69 
Specify aliases in one place, and make it more uniform which are defined
@calebzulawski
Add vectors of pointers
d3cfd7c
@calebzulawski
Use safe casts
7e96f5d
@calebzulawski
Implement scatter/gather with new pointer vector and add tests
4076ba8
@calebzulawski
Add missing safety comment
6b3c599
@calebzulawski
Fix wrapping pointer arithmetic
f10e591
@calebzulawski
Test a more useful pointer
da25087
@calebzulawski
Fix casts
e7cc021
@calebzulawski
Clarify addr and with_addr implementations
8a5a573
@calebzulawski
Update for new intrinsics
176cc81
@calebzulawski
Remove duplicate intrinsic
dadf98a
@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit de858e7 has been approved by workingjubilee

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 11, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
@workingjubilee workingjubilee mentioned this pull request May 11, 2023
Closed
@workingjubilee
Copy link
Member Author

@bors p=101

@bors
Copy link
Contributor

bors commented May 11, 2023

⌛ Testing commit de858e7 with merge c5f6f5892836916d1778cdae4ef9d0c87ab16693...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 11, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2023
@scottmcm scottmcm mentioned this pull request May 11, 2023
Merged
@workingjubilee
Copy link
Member Author

Ah right.

@workingjubilee
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2023

📌 Commit e4cecc1 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2023
@bors
Copy link
Contributor

bors commented May 12, 2023

⌛ Testing commit e4cecc1 with merge 26e0c57...

@compiler-errors
Copy link
Member

@bors p=1 (tree is open, bumping priority to a normal value in case it fails again and needs to be retried)

@bors
Copy link
Contributor

bors commented May 12, 2023

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 26e0c57 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2023
@bors bors merged commit 26e0c57 into rust-lang:master May 12, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 12, 2023
@bors bors mentioned this pull request May 12, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (26e0c57): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [0.5%, 4.1%] 2
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.9% [-4.7%, -1.6%] 5
All ❌✅ (primary) 2.3% [0.5%, 4.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 661.63s -> 660.274s (-0.20%)

@taiki-e taiki-e mentioned this pull request May 13, 2023
Merged
@dtolnay dtolnay mentioned this pull request May 16, 2023
Merged
@workingjubilee workingjubilee deleted the sync-simd-2023-may-10 branch July 31, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.