Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump windows crate 0.46 -> 0.48 #111393

Merged
merged 3 commits into from
May 12, 2023
Merged

bump windows crate 0.46 -> 0.48 #111393

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c03cce
bump windows crate 0.46 -> 0.48 in workspace
klensy May 9, 2023
a083986
add windows crate to allowed tidy list (why it worked before?)
klensy May 9, 2023
4f12412
tidy: sort lists in deps.rs using tidy-alphabetical
klensy May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/tools/tidy/src/deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,14 @@ const PERMITTED_RUSTC_DEPENDENCIES: &[&str] = &[
"winapi-i686-pc-windows-gnu",
"winapi-util",
"winapi-x86_64-pc-windows-gnu",
"windows-targets",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this seems to be required now because in the version change, the way the windows-targets crate was included has changed. before:

[target."cfg(not(windows_raw_dylib))".dependencies.windows-targets]
version = "0.42.2"

after:

[dependencies.windows-targets]
version = "0.48.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess cargo metadata just considered the non raw-dylib case before.

"windows_aarch64_msvc",
"windows_aarch64_gnullvm",
"windows_x86_64_gnullvm",
"windows_i686_msvc",
"windows_i686_gnu",
"windows_x86_64_msvc",
"windows_x86_64_gnu",
"writeable",
// this is a false-positive: it's only used by rustfmt, but because it's enabled through a
// feature, tidy thinks it's used by rustc as well.
Expand Down