-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dummy PR to check instrument-coverage test failures in CI #111116
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
3dbe4b1
to
197dd01
Compare
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
OK, this confirms that Now I'll try backing out the synthetic failure in |
OK, that test run succeeded, despite containing a Successful job link: https://github.com/rust-lang/rust/actions/runs/4868140937/jobs/8681353114 Now I'll try specifically modifying that file. |
r? @ghost |
Failed to set assignee to
|
r? @ghost |
Failed to set assignee to
|
My most recent change deliberately added another error to The corresponding test run inappropriately succeeded: https://github.com/rust-lang/rust/actions/runs/4868472221/jobs/8681992254 |
Now I'll try bumping |
Even modifying Successful job link: https://github.com/rust-lang/rust/actions/runs/4868994006/jobs/8683000830 Next I'm going to take the extreme measure of replacing |
This comment has been minimized.
This comment has been minimized.
Based on this evidence, I think the |
Based on my new hypothesis, I've modified Hopefully this should eliminate any subtle differences between GNU |
This comment has been minimized.
This comment has been minimized.
It seems clear that the person responsible for this headache is ... me, via #110942. There seems to be some subtle difference in how GNU To check whether things were working previously, I'll try removing those inserted |
The job Click to see the possible cause of the failure (guessed by this bot)
|
I've concluded that:
So the regexes in the original Makefile were correct on Linux, and broken on Mac. The changes in #110942 fixed them on Mac, but silently broke them on Linux (which is where they actually get checked in CI). I think I'll need to update the regexes to use |
☔ The latest upstream changes (presumably #111493) made this pull request unmergeable. Please resolve the merge conflicts. |
https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Do.20.60needs-profiler-support.60.20tests.20not.20run.20in.20CI.3F
Sorry for the noise; I was having some trouble getting the CI jobs to run at all, and I'm not sure how to politely avoid the auto-notifications.