Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the FileEncoder buffer size. #111088

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix the FileEncoder buffer size. #111088

merged 1 commit into from
May 15, 2023
+11 −33

Commits on May 14, 2023

  1. Fix the FileEncoder buffer size. 

    It allows a variable size, but in practice we always use the default of
8192 bytes. This commit fixes it to that size, which makes things
slightly faster because the size can be hard-wired in generated code.

The commit also:
- Rearranges some buffer capacity checks so they're all in the same form
  (`x > BUFSIZE`).
- Removes some buffer capacity assertions and comments about them. With
  an 8192 byte buffer, we're not in any danger of overflowing a `usize`.
    @nnethercote
    nnethercote committed May 14, 2023
    Configuration menu
    Copy the full SHA
    f2df861 View commit details
    Browse the repository at this point in the history