Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check-cfg implementation #111068

Merged
merged 4 commits into from
May 5, 2023
Merged

Improve check-cfg implementation #111068

merged 4 commits into from
May 5, 2023

Commits on May 5, 2023

  1. Use explicit instead of implicit control-flow for check-cfg parsing

    @Urgau
    Urgau committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ad6f4b7 View commit details
    Browse the repository at this point in the history

  2. Improve internal representation of check-cfg 

    This is done to simplify to relationship between names() and values()
but also make thing clearer (having an Any to represent that any values
are allowed) but also to allow the (none) + values expected cases that
wasn't possible before.
    @Urgau
    Urgau committed May 5, 2023
    Configuration menu
    Copy the full SHA
    d327d5b View commit details
    Browse the repository at this point in the history

  3. Improve check-cfg diagnostics (part 1)

    @Urgau
    Urgau committed May 5, 2023
    Configuration menu
    Copy the full SHA
    a5f8dba View commit details
    Browse the repository at this point in the history

  4. Improve check-cfg diagnostics (part 2)

    @Urgau
    Urgau committed May 5, 2023
    Configuration menu
    Copy the full SHA
    5364784 View commit details
    Browse the repository at this point in the history