Optimize dataflow-const-prop place-tracking infra #110820

cjgillot · 2023-04-25T18:27:47Z

Optimization opportunities found while investigating #110719

Computing places breadth-first ensures that we create short projections before deep projections, since the former are more likely to be propagated.

The most relevant is the pre-computation of flooded places. Callgrind showed flood_* methods and especially preorder_preinvoke were especially hot. This PR attempts to pre-compute the set of ValueIndex that preorder_invoke would visit.

Using this information, we make some PlaceIndex inaccessible when they contain no ValueIndex, allowing to skip computations for those places.

cc @jachris as original author

rustbot · 2023-04-25T18:27:53Z

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-04-25T18:27:55Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

oli-obk · 2023-05-03T11:25:27Z

@bors try @rust-timer queue

bors · 2023-05-03T11:25:38Z

⌛ Trying commit 3cfa1b1fa6c493ebbf8b4282eb92a161eb8563c7 with merge 8fffd5b5f897bb58af07618610dd7b1cef63d4e2...

bors · 2023-05-03T13:32:43Z

☀️ Try build successful - checks-actions
Build commit: 8fffd5b5f897bb58af07618610dd7b1cef63d4e2 (8fffd5b5f897bb58af07618610dd7b1cef63d4e2)

rust-timer · 2023-05-03T14:48:43Z

Finished benchmarking commit (8fffd5b5f897bb58af07618610dd7b1cef63d4e2): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 654.411s -> 654.14s (-0.04%)

cjgillot · 2023-05-05T21:09:17Z

The perf results are expected: those code paths are not enabled by default.

oli-obk

r=me with question answered as a comment or addressed otherwise

compiler/rustc_mir_dataflow/src/value_analysis.rs

oli-obk · 2023-05-08T08:30:05Z

compiler/rustc_mir_dataflow/src/value_analysis.rs

+        // We manually iterate instead of using `children` as we need to mutate `self`.
+        let mut next_child = self.places[root].first_child;
+        while let Some(child) = next_child {
+            self.cache_preorder_invoke(child);


how deep can this recursion get? We can have some very long projections from user code. A recursion limit could either cause a miscompilation or a hard error where there shouldn't be one, so maybe use ensure_sufficient_stack?

This recursion is required for correctness, so I added the ensure_sufficient_stack.
I don't think this is much of an issue in practice: we have a limit on the number of created values in register_with_filter.

oli-obk · 2023-05-08T08:52:11Z

@bors r+

bors · 2023-05-08T08:52:13Z

📌 Commit e858997ad21c730972d6f3f254ad6821f64f50f6 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-05-08T10:27:43Z

⌛ Testing commit e858997ad21c730972d6f3f254ad6821f64f50f6 with merge 390e41af383ca43944ee332c68e3f3cb1e84b122...

bors · 2023-05-08T11:35:58Z

💔 Test failed - checks-actions

cjgillot · 2023-05-09T19:39:13Z

@bors r=oli-obk

bors · 2023-05-09T19:39:14Z

📌 Commit ccc1da2 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-05-10T13:12:34Z

⌛ Testing commit ccc1da2 with merge b73d98147a1d4b1f392b6e38c052d8151e1a2dfa...

bors · 2023-05-10T13:17:20Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-05-10T13:21:23Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

cjgillot · 2023-05-10T15:51:58Z

@bors retry

Noratrieb · 2023-05-10T20:54:25Z

@bors p=50
PR CI seems to be normal recently, let's see whether it passes here

bors · 2023-05-10T20:54:33Z

⌛ Testing commit ccc1da2 with merge 9a767b6...

bors · 2023-05-11T00:17:11Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9a767b6 to master...

rust-timer · 2023-05-11T01:32:13Z

Finished benchmarking commit (9a767b6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-5.6%	[-5.6%, -5.6%]	1
Improvements ✅ (secondary)	-4.8%	[-4.8%, -4.8%]	1
All ❌✅ (primary)	-5.6%	[-5.6%, -5.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.2%, -2.3%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.519s -> 659.961s (0.22%)

rustbot assigned TaKO8Ki Apr 25, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 25, 2023

cjgillot mentioned this pull request Apr 26, 2023

Reimplement ConstProp using DataflowConstProp #110719

Closed

5 tasks

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 3, 2023

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 3, 2023

oli-obk approved these changes May 8, 2023

View reviewed changes

cjgillot force-pushed the faster-dcp branch from 3cfa1b1 to e858997 Compare May 8, 2023 08:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2023

cjgillot added 2 commits May 9, 2023 17:27

Make HasTop and HasBottom consts.

71138e9

Create tracked places breadth first.

7c3d551

cjgillot added 5 commits May 9, 2023 17:27

Trim the places that will not be used.

2b0bf3c

Extract handle_set_discriminant.

add5124

Do not flood on copy_nonoverlapping.

79c0737

Add a few comments.

2aa1c23

Prevent stack overflow.

ccc1da2

cjgillot force-pushed the faster-dcp branch from e858997 to ccc1da2 Compare May 9, 2023 17:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2023

bors merged commit 9a767b6 into rust-lang:master May 11, 2023

rustbot added this to the 1.71.0 milestone May 11, 2023

cjgillot deleted the faster-dcp branch May 11, 2023 06:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize dataflow-const-prop place-tracking infra #110820

Optimize dataflow-const-prop place-tracking infra #110820

cjgillot commented Apr 25, 2023

rustbot commented Apr 25, 2023

rustbot commented Apr 25, 2023

oli-obk commented May 3, 2023

This comment has been minimized.

bors commented May 3, 2023

bors commented May 3, 2023

This comment has been minimized.

rust-timer commented May 3, 2023

cjgillot commented May 5, 2023

oli-obk left a comment

oli-obk May 8, 2023

cjgillot May 8, 2023

oli-obk commented May 8, 2023

bors commented May 8, 2023

bors commented May 8, 2023

This comment has been minimized.

bors commented May 8, 2023

cjgillot commented May 9, 2023

bors commented May 9, 2023

bors commented May 10, 2023

bors commented May 10, 2023

rust-log-analyzer commented May 10, 2023

cjgillot commented May 10, 2023

Noratrieb commented May 10, 2023

bors commented May 10, 2023

bors commented May 11, 2023

rust-timer commented May 11, 2023

Optimize dataflow-const-prop place-tracking infra #110820

Optimize dataflow-const-prop place-tracking infra #110820

Conversation

cjgillot commented Apr 25, 2023

rustbot commented Apr 25, 2023

rustbot commented Apr 25, 2023

oli-obk commented May 3, 2023

This comment has been minimized.

bors commented May 3, 2023

bors commented May 3, 2023

This comment has been minimized.

rust-timer commented May 3, 2023

Overall result: no relevant changes - no action needed

cjgillot commented May 5, 2023

oli-obk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oli-obk commented May 8, 2023

bors commented May 8, 2023

bors commented May 8, 2023

This comment has been minimized.

bors commented May 8, 2023

cjgillot commented May 9, 2023

bors commented May 9, 2023

bors commented May 10, 2023

bors commented May 10, 2023

rust-log-analyzer commented May 10, 2023

cjgillot commented May 10, 2023

Noratrieb commented May 10, 2023

bors commented May 10, 2023

bors commented May 11, 2023

rust-timer commented May 11, 2023

Overall result: no relevant changes - no action needed