Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiletest] Add more test ignore reasons, needs- validation, and improved error messages #110319

Merged
merged 8 commits into from
Apr 16, 2023

Conversation

pietroalbini
Copy link
Member

This PR makes more improvements to the way compiletest ignoring headers are handled, following up on #108905:

  • Human-readable ignore reasons have been added for the remaining ignore causes (needs-* directives, *llvm* directives, and debugger version directives). All ignored tests should now have a human-readable reason.
  • The code handling needs-* directives has been refactored, and now invalid needs-* directive emit errors like ignore-* and only-*.
  • All errors are now displayed at startup (with line numbers) rather than just the first error of the first file.

This PR is best reviewed commit-by-commit.

r? @ehuss

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 14, 2023
@ehuss
Copy link
Contributor

ehuss commented Apr 15, 2023

Nice!

Again I have not validated the before/after ignore count, but from a cursory look at all the ignored tests it looks good.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2023

📌 Commit 34a52df has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2023
@bors
Copy link
Contributor

bors commented Apr 15, 2023

⌛ Testing commit 34a52df with merge 50b816f...

@bors
Copy link
Contributor

bors commented Apr 16, 2023

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 50b816f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2023
@bors bors merged commit 50b816f into rust-lang:master Apr 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 16, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (50b816f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.3% [-2.3%, -2.3%] 1

@pietroalbini pietroalbini deleted the pa-more-ignore-reasons branch April 16, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants