-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiletest] Add more test ignore reasons, needs-
validation, and improved error messages
#110319
Conversation
Nice! Again I have not validated the before/after ignore count, but from a cursory look at all the ignored tests it looks good. @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (50b816f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This PR makes more improvements to the way compiletest ignoring headers are handled, following up on #108905:
needs-*
directives,*llvm*
directives, and debugger version directives). All ignored tests should now have a human-readable reason.needs-*
directives has been refactored, and now invalidneeds-*
directive emit errors likeignore-*
andonly-*
.This PR is best reviewed commit-by-commit.
r? @ehuss