-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sysroot finding compatible with multiarch systems #110281
make sysroot finding compatible with multiarch systems #110281
Conversation
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
@rustbot label +beta-nominated |
Signed-off-by: ozkanonur <[email protected]>
a1251b1
to
2e98368
Compare
Any way we can write a test? |
The best way of testing this is having multiarch linux as CI runner(which I think we should have, just like having windows, mac and bsd runners cc @jyn514) which builds the compiler and runs the tests. Anything other than that would be supper annoying hacks. |
cc #102563 |
T-compiler is in favour of the beta backport but we should probably wait until it's merged in nightly. The backport will be reviewed again in a week. T-compiler meeting on Zulip. |
@bors r+ rollup=never (Given this doesn't have a test, I'm going to make sure we can bisect easily) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (7f94b31): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
[beta] backport This PR backports: - Encode def span for ConstParam rust-lang#110425 - Update to LLVM 16.0.2 rust-lang#110535 - Encode lifetime param spans too rust-lang#110469 - make sysroot finding compatible with multiarch systems rust-lang#110281 - Update awscli rust-lang#110952 - Temporarily disable the jobserver-error test rust-lang#110361 Also bumps us to the latest released stable, 1.69.0. r? `@cuviper`
Tested on Debian 11 multiarch, worked just fine.
resolves #109994